Sign upLogin

AjuntamentdeBarcelona/decidim-barcelona

View on GitHub
Star
decidim-ephemeral_participation/app/controllers/concerns/decidim/ephemeral_participation/ephemeral_participable.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method informable_ephemeral_participant? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def informable_ephemeral_participant?
          return false if verify_ephemeral_participant_path?
          return false if edit_ephemeral_participant_path?
          return false if update_ephemeral_participant_path?
          return false if unverifiable_ephemeral_participant_path?
Severity: Minor
Found in decidim-ephemeral_participation/app/controllers/concerns/decidim/ephemeral_participation/ephemeral_participable.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return false if request.flash.any?
Severity: Major
Found in decidim-ephemeral_participation/app/controllers/concerns/decidim/ephemeral_participation/ephemeral_participable.rb - About 30 mins to fix

    Method redirect_ephemeral_participant has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def redirect_ephemeral_participant
          return redirect_to(unverifiable_ephemeral_participant_path(current_user)) if redirect_to_unverifiable_ephemeral_participant_path?
          return redirect_to(ephemeral_participation_path) if redirect_to_ephemeral_participation_path?
          return redirect_to(edit_ephemeral_participant_path(current_user)) if redirect_to_edit_ephemeral_participant_path?
        end
    Severity: Minor
    Found in decidim-ephemeral_participation/app/controllers/concerns/decidim/ephemeral_participation/ephemeral_participable.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status