AlchemyCMS/alchemy_cms

View on GitHub

Showing 40 of 59 total issues

Class Page has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Page < BaseRecord
    include Alchemy::Hints
    include Alchemy::Logger
    include Alchemy::Taggable

Severity: Minor
Found in app/models/alchemy/page.rb - About 5 hrs to fix

Class PagesController has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

    class PagesController < Alchemy::Admin::BaseController
      include OnPageLayout::CallbacksRunner

      helper "alchemy/pages"

Severity: Minor
Found in app/controllers/alchemy/admin/pages_controller.rb - About 4 hrs to fix

Class Resource has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Resource
    attr_accessor :resource_relations, :model_associations
    attr_reader :model

    DEFAULT_SKIPPED_ATTRIBUTES = %w(id created_at creator_id)
Severity: Minor
Found in lib/alchemy/resource.rb - About 3 hrs to fix

File page.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Alchemy
  class Page < BaseRecord
    include Alchemy::Hints
    include Alchemy::Logger
    include Alchemy::Taggable
Severity: Minor
Found in app/models/alchemy/page.rb - About 2 hrs to fix

Class Content has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Content < BaseRecord
    include Alchemy::Logger
    include Alchemy::Hints

    # Concerns
Severity: Minor
Found in app/models/alchemy/content.rb - About 2 hrs to fix

Method pages has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def pages
      tree = []
      path = [{id: object.parent_id, children: tree}]
      page_list = object.self_and_descendants
      base_level = object.level - 1
Severity: Minor
Found in app/serializers/alchemy/page_tree_serializer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class InstallGenerator has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class InstallGenerator < ::Rails::Generators::Base
      desc "Installs Alchemy into your App."

      class_option :auto_accept,
        type: :boolean,
Severity: Minor
Found in lib/generators/alchemy/install/install_generator.rb - About 2 hrs to fix

Method try_seed_pages has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def try_seed_pages
        return unless page_seeds_file.file?

        if Alchemy::Page.exists?
          desc "Seeding Alchemy pages"
Severity: Minor
Found in lib/alchemy/seeder.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method delete_multiple has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def delete_multiple
        if request.delete? && params[:picture_ids].present?
          pictures = Picture.find(params[:picture_ids])
          names = []
          not_deletable = []
Severity: Minor
Found in app/controllers/alchemy/admin/pictures_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render_attribute has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def render_attribute(resource, attribute, options = {})
      attribute_value = resource.send(attribute[:name])
      if attribute[:relation]
        record = resource.send(attribute[:relation][:name])
        value = record.present? ? record.send(attribute[:relation][:attr_method]) : Alchemy.t(:not_found)
Severity: Minor
Found in lib/alchemy/resources_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method page_hash has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def page_hash(page, has_children, level, folded)
      p_hash = {
        id: page.id,
        name: page.name,
        public: page.public?,
Severity: Minor
Found in app/serializers/alchemy/page_tree_serializer.rb - About 1 hr to fix

Method pages has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def pages
      tree = []
      path = [{id: object.parent_id, children: tree}]
      page_list = object.self_and_descendants
      base_level = object.level - 1
Severity: Minor
Found in app/serializers/alchemy/page_tree_serializer.rb - About 1 hr to fix

Method delete_multiple has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def delete_multiple
        if request.delete? && params[:picture_ids].present?
          pictures = Picture.find(params[:picture_ids])
          names = []
          not_deletable = []
Severity: Minor
Found in app/controllers/alchemy/admin/pictures_controller.rb - About 1 hr to fix

Method render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def render
      return if picture.blank?

      output = caption ? img_tag + caption : img_tag

Severity: Minor
Found in app/models/alchemy/essence_picture_view.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visit_nodes has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def visit_nodes(nodes, my_left, parent, depth, tree, url, restricted)
Severity: Major
Found in app/controllers/alchemy/admin/pages_controller.rb - About 50 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        context "when a duplicate exists" do
          before do
            allow(essence).to receive(:duplicates).and_return([essence.dup])
          end

Severity: Minor
Found in lib/alchemy/test_support/essence_shared_examples.rb and 1 other location - About 50 mins to fix
lib/alchemy/test_support/essence_shared_examples.rb on lines 219..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          context "when a duplicate exists" do
            before do
              allow(essence).to receive(:duplicates).and_return([essence.dup])
            end

Severity: Minor
Found in lib/alchemy/test_support/essence_shared_examples.rb and 1 other location - About 50 mins to fix
lib/alchemy/test_support/essence_shared_examples.rb on lines 182..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method run_on_page_layout_callbacks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def run_on_page_layout_callbacks
        OnPageLayout.callbacks.each do |page_layout, callbacks|
          next unless call_page_layout_callback_for?(page_layout)

          callbacks.each do |callback|
Severity: Minor
Found in lib/alchemy/on_page_layout/callbacks_runner.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method remove_orphaned_contents has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def remove_orphaned_contents
        puts "\n## Removing orphaned contents"
        contents = Alchemy::Content.unscoped.all
        if contents.any?
          orphaned_contents = contents.select do |content|
Severity: Minor
Found in lib/alchemy/tasks/tidy.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_all_by_attributes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def get_all_by_attributes(attributes)
        return [] if attributes.blank?

        if attributes.is_a? Hash
          layouts = []
Severity: Minor
Found in lib/alchemy/page_layout.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language