Showing 29 of 58 total issues
Class Page
has 41 methods (exceeds 20 allowed). Consider refactoring. Open
class Page < BaseRecord
include Alchemy::Hints
include Alchemy::Logger
include Alchemy::Taggable
ElementEditor
has 40 functions (exceeds 20 allowed). Consider refactoring. Open
export class ElementEditor extends HTMLElement {
constructor() {
super()
// Add event listeners
Class PagesController
has 37 methods (exceeds 20 allowed). Consider refactoring. Open
class PagesController < ResourcesController
include OnPageLayout::CallbacksRunner
helper "alchemy/pages"
Class Resource
has 33 methods (exceeds 20 allowed). Consider refactoring. Open
class Resource
attr_accessor :resource_relations, :model_associations
attr_reader :model
DEFAULT_SKIPPED_ATTRIBUTES = %w[id created_at creator_id]
File element_editor.js
has 335 lines of code (exceeds 250 allowed). Consider refactoring. Open
import ImageLoader from "alchemy_admin/image_loader"
import fileEditors from "alchemy_admin/file_editors"
import pictureEditors from "alchemy_admin/picture_editors"
import SortableElements from "alchemy_admin/sortable_elements"
import IngredientAnchorLink from "alchemy_admin/ingredient_anchor_link"
File page.rb
has 297 lines of code (exceeds 250 allowed). Consider refactoring. Open
require_dependency "alchemy/page/fixed_attributes"
require_dependency "alchemy/page/page_layouts"
require_dependency "alchemy/page/page_scopes"
require_dependency "alchemy/page/page_natures"
require_dependency "alchemy/page/page_naming"
Method render_attribute
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def render_attribute(resource, attribute, options = {})
attribute_value = resource.send(attribute[:name])
if attribute[:relation]
record = resource.send(attribute[:relation][:name])
value = record.present? ? record.send(attribute[:relation][:attr_method]) : Alchemy.t(:not_found)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method pages
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def pages
tree = []
path = [{id: object.parent_id, children: tree}]
page_list = object.self_and_descendants.includes(:public_version, {language: :site})
base_level = object.level - 1
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method try_seed_pages
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def try_seed_pages
return unless page_seeds_file.file?
if Alchemy::Page.exists?
desc "Seeding Alchemy pages"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method delete_multiple
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def delete_multiple
if request.delete? && params[:picture_ids].present?
pictures = Picture.find(params[:picture_ids])
names = []
not_deletable = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function expand
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
expand() {
if (this.expanded && !this.compact) {
return Promise.resolve("Element is already expanded.")
}
Function filter
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
filter(term) {
const results = []
this.items.forEach(function (item) {
if (
Function checkPageDirtyness
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
function checkPageDirtyness(element) {
let callback = () => {}
if ($(element).is("form")) {
callback = function () {
Method page_hash
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def page_hash(page, level, folded)
p_hash = {
id: page.id,
name: page.name,
public: page.public?,
Function collapse
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
collapse() {
if (this.collapsed || this.compact || this.fixed) {
return Promise.resolve("Element is already collapsed.")
}
Function handleEvent
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
handleEvent(event) {
switch (event.type) {
case "click":
const elementEditor = event.target.closest("alchemy-element-editor")
if (elementEditor === this) {
Method pages
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def pages
tree = []
path = [{id: object.parent_id, children: tree}]
page_list = object.self_and_descendants.includes(:public_version, {language: :site})
base_level = object.level - 1
Function handleEvent
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
handleEvent(event) {
switch (event.type) {
case "click":
const elementEditor = event.target.closest("alchemy-element-editor")
if (elementEditor === this) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method delete_multiple
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def delete_multiple
if request.delete? && params[:picture_ids].present?
pictures = Picture.find(params[:picture_ids])
names = []
not_deletable = []
Method run_on_page_layout_callbacks
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def run_on_page_layout_callbacks
OnPageLayout.callbacks.each do |page_layout, callbacks|
next unless call_page_layout_callback_for?(page_layout)
callbacks.each do |callback|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"