Sign upLogin

AlexAegis/loreplotter

View on GitHub
Star
src/app/service/lore.service.ts

Summary

Maintainability
C
1 day
Test Coverage

Function constructor has 211 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    constructor(
        private engineService: EngineService,
        private databaseService: DatabaseService,
        private storeFacade: StoreFacade,
        private actorService: ActorService
Severity: Major
Found in src/app/service/lore.service.ts - About 1 day to fix

    File lore.service.ts has 288 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Enclosing, Node } from '@alexaegis/avl';
import { Offset } from '@angular-skyhook/core';
import { Injectable } from '@angular/core';
import { BaseDirective } from '@app/component/base-component.class';
import { normalizeFromWindow } from '@app/function';
    Severity: Minor
    Found in src/app/service/lore.service.ts - About 2 hrs to fix

      Function constructor has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          constructor(
        private engineService: EngineService,
        private databaseService: DatabaseService,
        private storeFacade: StoreFacade,
        private actorService: ActorService
      Severity: Minor
      Found in src/app/service/lore.service.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status