Sign upLogin

Anapher/Strive

View on GitHub
Star

Showing 735 of 735 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

using System.Threading.Tasks;
using Strive.Core.Services.Permissions.Gateways;
using Strive.Core.Services.Synchronization;

namespace Strive.Core.Services.Permissions
Severity: Major
Found in src/Services/ConferenceManagement/Strive.Core/Services/Permissions/SynchronizedTemporaryPermissionsProvider.cs and 1 other location - About 1 hr to fix
src/Services/ConferenceManagement/Strive.Core/Services/Media/SynchronizedMediaStateProvider.cs on lines 1..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

using System.Threading.Tasks;
using Strive.Core.Services.Media.Gateways;
using Strive.Core.Services.Synchronization;

namespace Strive.Core.Services.Media
Severity: Major
Found in src/Services/ConferenceManagement/Strive.Core/Services/Media/SynchronizedMediaStateProvider.cs and 1 other location - About 1 hr to fix
src/Services/ConferenceManagement/Strive.Core/Services/Permissions/SynchronizedTemporaryPermissionsProvider.cs on lines 1..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function selectAvailableInputDevicesFactory has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

export const selectAvailableInputDevicesFactory = () =>
   createSelector(selectLocalDevices, selectEquipmentConnections, getSource, (devices, equipment, source) => {
      const result = new Array<DeviceGroup>();

      if (devices) {
Severity: Minor
Found in src/Web/WebSPA/Client/src/features/settings/selectors.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DeviceSelector has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

export default function DeviceSelector({ devices, defaultName, className, selectedDevice, onChange, label }: Props) {
   const selectId = defaultName.toLowerCase() + '-select';
   const classes = useStyles();
   const dispatch = useDispatch();
   const { t } = useTranslation();
Severity: Minor
Found in src/Web/WebSPA/Client/src/features/settings/components/DeviceSelector.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ParticipantContextMenuTempPermissions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

export default function ParticipantContextMenuTempPermissions({ participantId }: Props) {
   const { t } = useTranslation();
   const tempPermissions = useSelector((state: RootState) => selectParticipantTempPermissions(state, participantId));
   const dispatch = useDispatch();
   const classes = useStyles();
Severity: Minor
Found in src/Web/WebSPA/Client/src/features/conference/components/ParticipantContextMenuTempPermissions.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        <IconButton
                           onClick={handleChange(width)}
                           className={clsx(classes.strokeButton, value === width && classes.strokeButtonSelected)}
                           title={`${width}px`}
                        >
Severity: Major
Found in src/Web/WebSPA/Client/src/features/whiteboard/components/LineWidthTool.tsx and 1 other location - About 1 hr to fix
src/Web/WebSPA/Client/src/features/whiteboard/components/FontSizeTool.tsx on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        <IconButton
                           onClick={handleChange(size)}
                           className={clsx(classes.strokeButton, value === size && classes.strokeButtonSelected)}
                           title={`${size}px`}
                        >
Severity: Major
Found in src/Web/WebSPA/Client/src/features/whiteboard/components/FontSizeTool.tsx and 1 other location - About 1 hr to fix
src/Web/WebSPA/Client/src/features/whiteboard/components/LineWidthTool.tsx on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

   return (
      <MenuItem id="scene-management-actions-poll" onClick={handleOpen}>
         <PollIcon fontSize="small" style={{ marginRight: 16 }} />
         {t('conference.scenes.poll.label')}
      </MenuItem>
Severity: Major
Found in src/Web/WebSPA/Client/src/features/scenes/components/poll/PollActionItem.tsx and 1 other location - About 1 hr to fix
src/Web/WebSPA/Client/src/features/scenes/components/whiteboard/WhiteboardActionItem.tsx on lines 18..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

   return (
      <MenuItem id="scene-management-actions-whiteboard" onClick={handleOpen}>
         <Draw fontSize="small" style={{ marginRight: 16 }} />
         {t('conference.whiteboard.whiteboard')}
      </MenuItem>
Severity: Major
Found in src/Web/WebSPA/Client/src/features/scenes/components/whiteboard/WhiteboardActionItem.tsx and 1 other location - About 1 hr to fix
src/Web/WebSPA/Client/src/features/scenes/components/poll/PollActionItem.tsx on lines 18..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function registerValidSW has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function registerValidSW(swUrl: string, config?: Config) {
  navigator.serviceWorker
    .register(swUrl)
    .then(registration => {
      registration.onupdatefound = () => {
Severity: Minor
Found in src/Web/WebSPA/Client/src/serviceWorker.ts - About 1 hr to fix

    Function handleKeyPress has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

       const handleKeyPress = (key: string, ctrl: boolean, shift: boolean) => {
      if (readOnly) return;

      if (key === 'z' && ctrl && !shift) {
         if (canUndo) onUndo();
    Severity: Minor
    Found in src/Web/WebSPA/Client/src/features/whiteboard/components/Whiteboard.tsx - About 1 hr to fix

      Function createReceiveTransport has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

         public async createReceiveTransport(): Promise<Transport> {
      this.pendingConsumers = [];

      const transportOptions = await this.client.createTransport({ producing: false, consuming: true });
      Severity: Minor
      Found in src/Web/WebSPA/Client/src/store/webrtc/WebRtcConnection.ts - About 1 hr to fix

        Function wrapControl has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function wrapControl(
   source: ProducerSource,
   device: AnyInputDevice | undefined,
   local: UseMediaState,
   equipment: Record<string, EquipmentConnection> | undefined,
        Severity: Minor
        Found in src/Web/WebSPA/Client/src/features/media/useDeviceManagement.ts - About 1 hr to fix

          Method ApplyScene has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private async Task ApplyScene(string conferenceId, string roomId, ActiveScene scene, SceneState currentState)
        {
            var sceneState = await CreateNewSceneState(conferenceId, roomId, scene, currentState);
            await _sceneRepository.SetSceneState(conferenceId, roomId, sceneState);
          Severity: Minor
          Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/UseCases/UpdateScenesUseCase.cs - About 1 hr to fix

            Method HandleInternal has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    private async Task<SuccessOrError<Unit>> HandleInternal(PatchConferenceRequest request,
            CancellationToken cancellationToken)
        {
            var (conferenceId, patch) = request;
            Severity: Minor
            Found in src/Services/ConferenceManagement/Strive.Core/Services/ConferenceManagement/UseCases/PatchConferenceRequestHandler.cs - About 1 hr to fix

              Method TalkingStick_Moderated_Return_RemovePresenter has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      [Fact]
        public async Task TalkingStick_Moderated_Return_RemovePresenter()
        {
            // arrange
            var (conn, conference) = await ConnectToOpenedConference();
              Severity: Minor
              Found in src/Services/ConferenceManagement/Strive.IntegrationTests/Services/SceneTests.cs - About 1 hr to fix

                Function executeCommand has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                         const executeCommand = async () => {
            try {
               switch (command.action) {
                  case 'enable':
                     await control.enable();
                Severity: Minor
                Found in src/Web/WebSPA/Client/src/features/equipment/components/Equipment.tsx - About 1 hr to fix

                  Function mapStats has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  const mapStats = (report: RTCStatsReport): StatsRow[] => {
   const stats = Array.from(report);
   return [
      ...stats
         .filter(([, value]) => value.type === 'transport')
                  Severity: Minor
                  Found in src/Web/WebSPA/Client/src/features/conference/components/troubleshoot/troubleshoot-connection/TransportStats.tsx - About 1 hr to fix

                    Function RoomsList has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export default function RoomsList() {
   const classes = useStyles();

   const rooms = useSelector(selectRoomViewModels);
   const participants = useSelector(selectParticipants);
                    Severity: Minor
                    Found in src/Web/WebSPA/Client/src/features/rooms/components/RoomsList.tsx - About 1 hr to fix

                      Function App has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function App() {
   return (
      <MuiPickersUtilsProvider utils={LuxonUtils}>
         <ThemeProvider theme={theme}>
            <MaterialUiToaster />
                      Severity: Minor
                      Found in src/Web/WebSPA/Client/src/App.tsx - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language