Sign upLogin

Anapher/Strive

View on GitHub
Star

Showing 735 of 735 total issues

Method OpenBreakoutRoomsDto has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public record OpenBreakoutRoomsDto(int Amount, DateTimeOffset? Deadline, string? Description,
        string[][]? AssignedRooms);
Severity: Minor
Found in src/Services/ConferenceManagement/Strive/Hubs/Core/Dtos/OpenBreakoutRoomsDto.cs - About 35 mins to fix

    Method BuildSceneStack has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            private async Task<IReadOnlyList<IScene>> BuildSceneStack(string conferenceId, string roomId,
            ActiveScene activeScene, SceneState currentState, IReadOnlyList<IScene> availableScenes)
    Severity: Minor
    Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/UseCases/UpdateScenesUseCase.cs - About 35 mins to fix

      Method IsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public ValueTask<SceneUpdate> IsUpdateRequired(string conferenceId, string roomId, string syncObjId,
            object synchronizedObject, object? previousValue)
      Severity: Minor
      Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/Providers/AutonomousSceneProvider.cs - About 35 mins to fix

        Method IsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public async ValueTask<SceneUpdate> IsUpdateRequired(string conferenceId, string roomId, string syncObjId,
            object synchronizedObject, object? previousValue)
        Severity: Minor
        Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/Providers/TalkingStick/TalkingStickSceneProvider.cs - About 35 mins to fix

          Method SendEquipmentCommandRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public record SendEquipmentCommandRequest(Participant Participant, string ConnectionId, ProducerSource Source,
        string? DeviceId, EquipmentCommandType Action) : IRequest;
          Severity: Minor
          Found in src/Services/ConferenceManagement/Strive.Core/Services/Equipment/Requests/SendEquipmentCommandRequest.cs - About 35 mins to fix

            Method FetchSceneProvidersWithRequiredUpdate has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                        string conferenceId, string roomId, string syncObjId, object syncObj, object? previousSyncObj)
            Severity: Minor
            Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/NotificationHandlers/SynchronizedObjectUpdatedNotificationHandler.cs - About 35 mins to fix

              Method TestTranslateStartEndIndex has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      public void TestTranslateStartEndIndex(int start, int end, int total, int expectedStart, int expectedEnd)
              Severity: Minor
              Found in src/Services/ConferenceManagement/Strive.Core.Tests/Utilities/IndexUtilsTests.cs - About 35 mins to fix

                Method InternalIsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        protected override async ValueTask<bool> InternalIsUpdateRequired(string conferenceId, string roomId,
            string syncObjId, object synchronizedObject, object? previousValue)
                Severity: Minor
                Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/Providers/WhiteboardSceneProvider.cs - About 35 mins to fix

                  Method InternalIsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          protected override async ValueTask<bool> InternalIsUpdateRequired(string conferenceId, string roomId,
            string syncObjId, object synchronizedObject, object? previousValue)
                  Severity: Minor
                  Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/Providers/BreakoutRoomSceneProvider.cs - About 35 mins to fix

                    Method SceneBuilderContext has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public record SceneBuilderContext(string ConferenceId, string RoomId, IEnumerable<IScene> AvailableScenes,
        SceneOptions Options, IReadOnlyList<IScene> PreviousStack);
                    Severity: Minor
                    Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/SceneBuilderContext.cs - About 35 mins to fix

                      Method PushLiveActionRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public record PushLiveActionRequest(string ConferenceId, string RoomId, string ParticipantId, string WhiteboardId,
        CanvasLiveAction Action) : IRequest;
                      Severity: Minor
                      Found in src/Services/ConferenceManagement/Strive.Core/Services/WhiteboardService/Requests/PushLiveActionRequest.cs - About 35 mins to fix

                        Method InternalIsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                protected override ValueTask<bool> InternalIsUpdateRequired(string conferenceId, string roomId,
            string syncObjId, object synchronizedObject, object? previousValue)
                        Severity: Minor
                        Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/Providers/PollSceneProvider.cs - About 35 mins to fix

                          Method InternalIsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  protected override async ValueTask<bool> InternalIsUpdateRequired(string conferenceId, string roomId,
            string syncObjId, object synchronizedObject, object? previousValue)
                          Severity: Minor
                          Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/Providers/ScreenShareSceneProvider.cs - About 35 mins to fix

                            Method InternalIsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    protected override ValueTask<bool> InternalIsUpdateRequired(string conferenceId, string roomId,
            string syncObjId, object synchronizedObject, object? previousValue)
                            Severity: Minor
                            Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/Providers/DefaultScenesProvider.cs - About 35 mins to fix

                              Method IsUpdateRequired has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      public async ValueTask<SceneUpdate> IsUpdateRequired(string conferenceId, string roomId, string syncObjId,
            object synchronizedObject, object? previousValue)
                              Severity: Minor
                              Found in src/Services/ConferenceManagement/Strive.Core/Services/Scenes/ContentSceneProvider.cs - About 35 mins to fix

                                Method Poll has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public record Poll(string Id, PollInstruction Instruction, PollConfig Config, string? RoomId,
        DateTimeOffset CreatedOn);
                                Severity: Minor
                                Found in src/Services/ConferenceManagement/Strive.Core/Services/Poll/Poll.cs - About 35 mins to fix

                                  Method ChatMessageReceivedNotification has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public record ChatMessageReceivedNotification(string ConferenceId, IReadOnlyList<Participant> Participants,
        ChatMessage ChatMessage, ChatChannel Channel, int TotalMessagesInChannel) : INotification;
                                  Severity: Minor
                                  Found in src/Services/ConferenceManagement/Strive.Core/Services/Chat/Notifications/ChatMessageReceivedNotification.cs - About 35 mins to fix

                                    Method PushActionRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        public record PushActionRequest (string ConferenceId, string RoomId, string WhiteboardId, string ParticipantId,
        CanvasPushAction Action) : IRequest<WhiteboardUpdatedResponse>;
                                    Severity: Minor
                                    Found in src/Services/ConferenceManagement/Strive.Core/Services/WhiteboardService/Requests/PushActionRequest.cs - About 35 mins to fix

                                      Method SynchronizedWhiteboardInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          public record SynchronizedWhiteboardInfo(string FriendlyName, bool AnyoneCanEdit, WhiteboardCanvas Canvas,
        IReadOnlyDictionary<string, SynchronizedParticipantState> ParticipantStates, int Version);
                                      Severity: Minor
                                      Found in src/Services/ConferenceManagement/Strive.Core/Services/WhiteboardService/SynchronizedWhiteboardInfo.cs - About 35 mins to fix

                                        Similar blocks of code found in 6 locations. Consider refactoring.
                                        Open

                                                [Fact]
        public void Validate_SelectedDecimalStepDoesNotMatch_ReturnError()
        {
            // act
            var result = _validator.Validate(new NumericInstruction(null, null, 0.5M), new NumericAnswer(0.75M));
                                        Severity: Major
                                        Found in src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/Types/Numeric/NumericAnswerValidatorTests.cs and 5 other locations - About 35 mins to fix
                                        src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/Types/Numeric/NumericAnswerValidatorTests.cs on lines 11..19
                                        src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/Types/Numeric/NumericAnswerValidatorTests.cs on lines 21..29
                                        src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/Types/Numeric/NumericAnswerValidatorTests.cs on lines 31..39
                                        src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/Types/Numeric/NumericAnswerValidatorTests.cs on lines 51..59
                                        src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/Types/Numeric/NumericAnswerValidatorTests.cs on lines 61..69

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 67.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language