Anapher/Strive

View on GitHub

Showing 735 of 735 total issues

Avoid too many return statements within this method.
Open

                        return Redirect("~/");

    Avoid too many return statements within this method.
    Open

                            return Redirect(model.ReturnUrl);

      Avoid too many return statements within this method.
      Open

                      return year;

        Avoid too many return statements within this method.
        Open

                    if (specificYears.Contains(year)) return year;

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      var action = new UpateCanvasAction(new[]
                      {
                          new CanvasObjectPatch(new JsonPatchDocument<CanvasObject>().Add(x => x.ScaleY, 2.0), "1"),
                      }, ParticipantId);
          src/Services/ConferenceManagement/Strive.Core.Tests/Services/WhiteboardService/Actions/UpdateCanvasActionTests.cs on lines 25..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this method.
          Open

                      return CronExpression.Parse(cronExp).GetNextOccurrence(now, timeZone);

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        await conn.SyncObjects.AssertSyncObject<SynchronizedScene>(
                            SynchronizedScene.SyncObjId(RoomOptions.DEFAULT_ROOM_ID),
                            syncObj => Assert.Equal(AutonomousScene.Instance, syncObj.SelectedScene));
            src/Services/ConferenceManagement/Strive.IntegrationTests/Services/SceneTests.cs on lines 111..113
            src/Services/ConferenceManagement/Strive.IntegrationTests/Services/SceneTests.cs on lines 231..233

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        _repository.Setup(x => x.GetPollAnswer(_participant, PollId))
                            .ReturnsAsync(new PollAnswerWithKey(new MultipleChoiceAnswer(new[] {"B"}), "123"));
            src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/UseCase/SubmitAnswerUseCaseTests.cs on lines 161..162

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        var action = new UpateCanvasAction(new[]
                        {
                            new CanvasObjectPatch(new JsonPatchDocument<CanvasObject>().Add(x => x.ScaleY, 2.0), "1"),
                        }, ParticipantId);
            src/Services/ConferenceManagement/Strive.Core.Tests/Services/WhiteboardService/Actions/UpdateCanvasActionTests.cs on lines 52..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this method.
            Open

                        return nextYear;

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          _repository.Setup(x => x.GetPollAnswer(_participant, PollId))
                              .ReturnsAsync(new PollAnswerWithKey(new MultipleChoiceAnswer(new[] {"B"}), "123"));
              src/Services/ConferenceManagement/Strive.Core.Tests/Services/Poll/UseCase/SubmitAnswerUseCaseTests.cs on lines 141..142

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this method.
              Open

                          return View(vm);

                Avoid too many return statements within this method.
                Open

                                if (start > year) return start;

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              Assert.Equal(new[] {typeof(PanCanvasAction), typeof(DeleteCanvasAction)},
                                  updatedWhiteboard.ParticipantStates[ParticipantId].RedoList.Select(x => x.Action.GetType()));
                  src/Services/ConferenceManagement/Strive.Core.Tests/Services/WhiteboardService/UseCases/RedoUseCaseTests.cs on lines 123..124

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                           <TabPanel value={value} index={1} className={classes.tab}>
                              <AudioSettings />
                           </TabPanel>
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 83..85
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 89..91
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 92..94
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 95..97
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 98..100

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              middleware.Setup(x => x(It.IsAny<ServiceInvokerContext>()))
                                  .ReturnsAsync(SuccessOrError<Unit>.Succeeded(Unit.Value));
                  src/Services/ConferenceManagement/Strive.Tests/Hubs/Core/Services/ServiceRequestBuilderTests.cs on lines 149..150

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  export type SuccessOrError<T = never> =
                     | ([T] extends [never] ? SuccessOrErrorSucceededWithoutResult : SuccessOrErrorSucceeded<T>)
                     | SuccessOrErrorFailed;
                  Severity: Minor
                  Found in src/Services/SFU/src/common-types.ts and 1 other location - About 30 mins to fix
                  src/Web/WebSPA/Client/src/communication-types.ts on lines 24..26

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                        .concat(participantsInRoom.map((x) => allParticipants[x]).filter((x): x is Participant => !!x))
                  src/Web/WebSPA/Client/src/features/chat/components/ParticipantsTyping.tsx on lines 25..27
                  src/Web/WebSPA/Client/src/features/scenes/components/talkingStick/PassStickList.tsx on lines 25..27

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        setPlaySoundOnOpen(state, { payload }: PayloadAction<boolean>) {
                           state.obj.conference.playSoundOnOpen = payload;
                        },
                  Severity: Minor
                  Found in src/Web/WebSPA/Client/src/features/settings/reducer.tsx and 1 other location - About 30 mins to fix
                  src/Web/WebSPA/Client/src/features/settings/reducer.tsx on lines 74..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                           <TabPanel value={value} index={2} className={classes.tab}>
                              <WebcamSettings />
                           </TabPanel>
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 83..85
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 86..88
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 92..94
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 95..97
                  src/Web/WebSPA/Client/src/features/settings/components/Settings.tsx on lines 98..100

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language