src/Services/Identity/Identity.API/Quickstart/Account/AccountController.cs
Method Login has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
[HttpPost]
[ValidateAntiForgeryToken]
public async Task<IActionResult> Login(LoginInputModel model, string button)
{
// check if we are in the context of an authorization requestMethod Login has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring. Open
Open
[HttpPost]
[ValidateAntiForgeryToken]
public async Task<IActionResult> Login(LoginInputModel model, string button)
{
// check if we are in the context of an authorization request- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method BuildLoginViewModelAsync has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private async Task<LoginViewModel> BuildLoginViewModelAsync(string returnUrl)
{
var context = await _interaction.GetAuthorizationContextAsync(returnUrl);
if (context?.IdP != null && await _schemeProvider.GetSchemeAsync(context.IdP) != null)
{Method BuildLoggedOutViewModelAsync has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private async Task<LoggedOutViewModel> BuildLoggedOutViewModelAsync(string logoutId)
{
// get context information (client name, post logout redirect URI and iframe for federated signout)
var logout = await _interaction.GetLogoutContextAsync(logoutId);
Avoid too many return statements within this method. Open
Open
return Redirect(model.ReturnUrl);Avoid too many return statements within this method. Open
Open
return Redirect("~/");Avoid too many return statements within this method. Open
Open
return Redirect(model.ReturnUrl);Avoid too many return statements within this method. Open
Open
return View(vm);