Sign upLogin

AndrewWalsh/at-your-service

View on GitHub
Star

Showing 89 of 89 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test.each(equalSampleCases)(
  "isEqual returns true when samples are equal",
  (a, b) => {
    expect(a.isEqual(b)).toBe(true);
  }
Severity: Minor
Found in src/data-types/sample.test.ts and 1 other location - About 35 mins to fix
src/data-types/sample.test.ts on lines 54..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test.each(unequalSampleCases)(
  "isEqual returns false when samples are not equal",
  (a, b) => {
    expect(a.isEqual(b)).toBe(false);
  }
Severity: Minor
Found in src/data-types/sample.test.ts and 1 other location - About 35 mins to fix
src/data-types/sample.test.ts on lines 36..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return passthrough()
Severity: Major
Found in demo/public/mockServiceWorker.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return passthrough()
    Severity: Major
    Found in docs/mockServiceWorker.js - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            <Link href="https://www.npmjs.com/package/at-your-service" isExternal>
        <Icon as={DiNpm} height="128px" width="128px" />
      </Link>
      Severity: Minor
      Found in demo/src/Footer.tsx and 1 other location - About 30 mins to fix
      demo/src/Footer.tsx on lines 16..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

            return passthrough()
      Severity: Major
      Found in docs/mockServiceWorker.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (!(event.request.url.indexOf("http") === 0)) return;
        Severity: Major
        Found in src/_not_exported/at-your-service-sw.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return passthrough()
          Severity: Major
          Found in demo/public/mockServiceWorker.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  <Link href="https://github.com/AndrewWalsh/at-your-service" isExternal>
        <Icon as={DiGithubFull} height="128px" width="128px" />
      </Link>
            Severity: Minor
            Found in demo/src/Footer.tsx and 1 other location - About 30 mins to fix
            demo/src/Footer.tsx on lines 19..21

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language