AndyObtiva/glimmer

View on GitHub

Showing 18 of 32 total issues

Class ModelBinding has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ModelBinding
      include Observable
      include Observer
      
      ARRAY_INDEXED_PROPERTY_ARGUMENT_REGEX = /\d+/
Severity: Minor
Found in lib/glimmer/data_binding/model_binding.rb - About 3 hrs to fix

    Method method_missing has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def method_missing(method_symbol, *args, &block)
        # This if statement speeds up Glimmer in girb or whenever directly including on main object
        is_excluded = Config.excluded_keyword_checkers.any? do |checker|
          instance_exec(method_symbol, *args, &checker)
        end
    Severity: Minor
    Found in lib/glimmer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_nested_observers has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_nested_observers(observer)
            nested_property_observers = nested_property_observers_for(observer)
            Concurrent::Array.new(nested_models.zip(nested_property_names)).each_with_index do |zip, i|
              model, property_name = zip
              nested_property_observer = nested_property_observers[property_name]
    Severity: Minor
    Found in lib/glimmer/data_binding/model_binding.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            def add_upcased_static_expression(static_expression)
              if static_expression.class.upcased?
                Glimmer::Config.logger.info {"Adding upcased static expression: #{static_expression.class.name}"}
                keyword = static_expression.class.keyword
                static_expression_dsl = static_expression.class.dsl
    Severity: Major
    Found in lib/glimmer/dsl/engine.rb and 1 other location - About 1 hr to fix
    lib/glimmer/dsl/engine.rb on lines 183..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            def add_capitalized_static_expression(static_expression)
              if static_expression.class.capitalized?
                Glimmer::Config.logger.info {"Adding capitalized static expression: #{static_expression.class.name}"}
                keyword = static_expression.class.keyword
                static_expression_dsl = static_expression.class.dsl
    Severity: Major
    Found in lib/glimmer/dsl/engine.rb and 1 other location - About 1 hr to fix
    lib/glimmer/dsl/engine.rb on lines 172..179

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method observe has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def observe(observable, *args)
            options = args.last.is_a?(Hash) ? args.last : {}
            return if observable.nil?
            return if options[:ignore_frozen] && observable.frozen?
            unless observable.is_a?(Observable)
    Severity: Minor
    Found in lib/glimmer/data_binding/observer.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def reject!(&block)
            if block_given?
              old_hash = self.dup
              super(&block).tap do |new_hash|
                deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def delete_if(&block)
            if block_given?
              old_hash = self.dup
              super(&block).tap do |new_hash|
                deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def select!(&block)
            if block_given?
              old_hash = self.dup
              super(&block).tap do |new_hash|
                deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def keep_if(&block)
            if block_given?
              old_hash = self.dup
              super(&block).tap do |new_hash|
                deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def filter!(&block)
            if block_given?
              old_hash = self.dup
              super(&block).tap do |new_hash|
                deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method call has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def call(value, *extra_args)
            return if model.nil?
            converted_value = value
            invoke_property_writer(model, model.is_a?(Hash) && !property_indexed?(property_name) ? property_name : "#{property_name}=", converted_value) unless converted_value == evaluate_property || property_name.nil?
          end
    Severity: Minor
    Found in lib/glimmer/data_binding/model_binding.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              changed_keys = old_hash.keys + new_hash.keys
              changed_keys.each do |changed_key|
                old_value = old_hash[changed_key]
                if new_hash[changed_key] != old_value
                  unregister_dependent_observers(changed_key, old_value)
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb and 1 other location - About 25 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 292..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                changed_keys = old_hash.keys + new_hash.keys
                changed_keys.each do |changed_key|
                  old_value = old_hash[changed_key]
                  if new_hash[changed_key] != old_value
                    unregister_dependent_observers(changed_key, old_value)
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb and 1 other location - About 25 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 273..279

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method add_observer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_observer(observer, *args)
            options = args.last.is_a?(Hash) ? args.pop : {}
            element_properties = args.flatten.compact.uniq
            return observer if has_observer?(observer) && has_observer_element_properties?(observer, element_properties)
            property_observer_list[observer] = options
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_array.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method can_interpret? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def can_interpret?(parent, keyword, *args, &block)
            result = false
            result ||= keyword.downcase == keyword if self.class.downcased?
            result ||= keyword.upcase == keyword if self.class.upcased?
            result ||= keyword.capitalize == keyword if self.class.capitalized?
    Severity: Minor
    Found in lib/glimmer/dsl/static_expression.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def select!(&block)
            if block_given?
              old_array = Array.new(self)
              super(&block).tap do
                (old_array - self).each do |old_value|
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_array.rb and 1 other location - About 20 mins to fix
    lib/glimmer/data_binding/observable_array.rb on lines 289..301

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def filter!(&block)
            if block_given?
              old_array = Array.new(self)
              super(&block).tap do
                (old_array - self).each do |old_value|
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_array.rb and 1 other location - About 20 mins to fix
    lib/glimmer/data_binding/observable_array.rb on lines 274..286

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language