Sign upLogin

Angelmaneuver/command-launcher

View on GitHub
Star
src/includes/guide/menu/edit/base.ts

Summary

Maintainability
D
2 days
Test Coverage
A
100%

File base.ts has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { QuickPickItem }         from 'vscode';
import {
    InputStep,
    MultiStepInput,
}                                from '../../../utils/multiStepInput';
Severity: Minor
Found in src/includes/guide/menu/edit/base.ts - About 3 hrs to fix

    Function setSettingGuide has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private setSettingGuide(label: string): () => Promise<void> {
        let [key, itemId, additionalTitle, guideGroupId] = ['BaseInputGuide', '', '', this.guideGroupId];
        let optionState: Partial<State>                  = {};
        let args: Array<unknown>                         = [];
        let guide: Guide;
    Severity: Major
    Found in src/includes/guide/menu/edit/base.ts - About 2 hrs to fix

      Function save has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected async save(): Promise<void> {
        const hierarchy                          = [...this.hierarchy];
        const pre                                = Optional.ofNullable(hierarchy.pop()).orElseThrow(ReferenceError('Edit target not found...'));
        const name                               = Optional.ofNullable(this.guideGroupResultSet[this.settings.itemId.name]).orElseNonNullable(pre) as string;
        const original                           = this.settings.cloneDeep(this.hierarchy, this.location);
      Severity: Minor
      Found in src/includes/guide/menu/edit/base.ts - About 1 hr to fix

        Function setMenuItems has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private setMenuItems(): void {
        if (this.isRoot) {
            this.setRootItems();
        } else {
            if (Constant.DATA_TYPE.folder === this.type) {
        Severity: Minor
        Found in src/includes/guide/menu/edit/base.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setMenuItems has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private setMenuItems(): void {
        if (this.isRoot) {
            this.setRootItems();
        } else {
            if (Constant.DATA_TYPE.folder === this.type) {
        Severity: Minor
        Found in src/includes/guide/menu/edit/base.ts - About 1 hr to fix

          Function getExecute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected getExecute(label: string | undefined): (() => Promise<void>) | undefined {
        this.initialValue    = undefined;
        this.state.hierarchy = [...this.hierarchy];

        switch (label) {
          Severity: Minor
          Found in src/includes/guide/menu/edit/base.ts - About 1 hr to fix

            Function setSettingGuide has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private setSettingGuide(label: string): () => Promise<void> {
        let [key, itemId, additionalTitle, guideGroupId] = ['BaseInputGuide', '', '', this.guideGroupId];
        let optionState: Partial<State>                  = {};
        let args: Array<unknown>                         = [];
        let guide: Guide;
            Severity: Minor
            Found in src/includes/guide/menu/edit/base.ts - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        case items.autoRun.label:
                key                         = 'AutoRunSettingGuide';
                optionState['initialValue'] = (
                    this.guideGroupResultSet[this.settings.itemId.autoRun]
                        ? this.guideGroupResultSet[this.settings.itemId.autoRun]
            Severity: Major
            Found in src/includes/guide/menu/edit/base.ts and 1 other location - About 3 hrs to fix
            src/includes/guide/menu/edit/base.ts on lines 309..316

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        case items.singleton.label:
                key                         = 'SingletonSettingGuide';
                optionState['initialValue'] = (
                    this.guideGroupResultSet[this.settings.itemId.singleton]
                        ? this.guideGroupResultSet[this.settings.itemId.singleton]
            Severity: Major
            Found in src/includes/guide/menu/edit/base.ts and 1 other location - About 3 hrs to fix
            src/includes/guide/menu/edit/base.ts on lines 301..308

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status