Angelmaneuver/command-launcher

View on GitHub
src/includes/settings/extension.ts

Summary

Maintainability
C
1 day
Test Coverage
A
96%

ExtensionSetting has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

export class ExtensionSetting extends SettingBase {
    private _commonCommands:    Record<string, unknown>;
    private _commands:          Record<string, unknown>;
    private _enableHistory:     boolean;
    private _keepHistoryNumber: number;
Severity: Minor
Found in src/includes/settings/extension.ts - About 3 hrs to fix

    File extension.ts has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { ConfigurationTarget } from 'vscode';
    import * as _                  from 'lodash';
    import { SettingBase }         from './base';
    import { Optional }            from '../utils/base/optional';
    import { LOCATION, Location }  from '../utils/base/type';
    Severity: Minor
    Found in src/includes/settings/extension.ts - About 2 hrs to fix

      Function getSurface has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private getSurface(location: Location, ordered: Record<string, unknown>, other: Record<string, unknown>): void {
              const records: Record<string, unknown> = this.getLocationRecords(location);
      
              Object.keys(records).forEach((key) => {
                  const record = records[key] as Record<string, unknown>;
      Severity: Minor
      Found in src/includes/settings/extension.ts - About 1 hr to fix

        Function sort has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public sort(hierarchy: Array<string>, location: Location, sortWithName: boolean = true): void {
                const registerd                         = this.cloneDeep(hierarchy, location);
                const ordered:  Record<string, unknown> = {};
                const target                            = this.lookup(hierarchy, location, this.lookupMode.read);
        
        
        Severity: Minor
        Found in src/includes/settings/extension.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public async updateCommands(): Promise<void> {
                  if (0 === Object.keys(this._commands).length) {
                      return this.remove(CONFIG_ITEMS.commands);
                  } else {
                      return this.update(CONFIG_ITEMS.commands, this._commands);
          Severity: Major
          Found in src/includes/settings/extension.ts and 1 other location - About 2 hrs to fix
          src/includes/settings/extension.ts on lines 84..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public async updateCommonCommands(): Promise<void> {
                  if (0 === Object.keys(this._commonCommands).length) {
                      return this.remove(CONFIG_ITEMS.commonCommands);
                  } else {
                      return this.update(CONFIG_ITEMS.commonCommands, this._commonCommands);
          Severity: Major
          Found in src/includes/settings/extension.ts and 1 other location - About 2 hrs to fix
          src/includes/settings/extension.ts on lines 100..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status