Sign upLogin

Apollon77/daikin-controller

View on GitHub
Star
src/models/ControlInfo.ts

Summary

Maintainability
D
2 days
Test Coverage

Function getRequestDict has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    public getRequestDict(): RequestDict {
        const dict: RequestDict = {};
        if (this.power === undefined) throw new Error('Required Field power do not exists');
        if (this.mode === undefined) throw new Error('Required Field mode do not exists');
        if (this.targetTemperature === undefined) throw new Error('Required Field targetTemperature do not exists');
Severity: Minor
Found in src/models/ControlInfo.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function overwrite has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public overwrite(obj: Partial<ControlInfo>) {
        if (obj.power !== undefined) this.power = obj.power;
        if (obj.mode !== undefined) this.mode = obj.mode;
        if (obj.targetTemperature !== undefined) this.targetTemperature = obj.targetTemperature;
        if (obj.targetHumidity !== undefined) this.targetHumidity = obj.targetHumidity;
Severity: Minor
Found in src/models/ControlInfo.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRequestDict has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public getRequestDict(): RequestDict {
        const dict: RequestDict = {};
        if (this.power === undefined) throw new Error('Required Field power do not exists');
        if (this.mode === undefined) throw new Error('Required Field mode do not exists');
        if (this.targetTemperature === undefined) throw new Error('Required Field targetTemperature do not exists');
Severity: Major
Found in src/models/ControlInfo.ts - About 2 hrs to fix

    Function parseResponse has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static parseResponse(dict: ResponseDict, cb: DaikinResponseCb<ControlInfo>): void {
        const result = new ControlInfo();
        result.power = DaikinDataParser.resolveBool(dict, 'pow', Power);
        result.mode = DaikinDataParser.resolveInteger(dict, 'mode', Mode);
        result.targetTemperature = DaikinDataParser.resolveFloat(dict, 'stemp', AlternativeTemperatureTargets);
    Severity: Minor
    Found in src/models/ControlInfo.ts - About 1 hr to fix

      Function overwrite has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public overwrite(obj: Partial<ControlInfo>) {
        if (obj.power !== undefined) this.power = obj.power;
        if (obj.mode !== undefined) this.mode = obj.mode;
        if (obj.targetTemperature !== undefined) this.targetTemperature = obj.targetTemperature;
        if (obj.targetHumidity !== undefined) this.targetHumidity = obj.targetHumidity;
      Severity: Minor
      Found in src/models/ControlInfo.ts - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status