Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
boost/update.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method intern_update has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function intern_update(&$content, $currentVersion)
{
    PHPWS_Core::initModClass('users', 'Permission.php');

    switch ($currentVersion) {
Severity: Major
Found in boost/update.php - About 5 hrs to fix

The function intern_update() has 140 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

function intern_update(&$content, $currentVersion)
{
    PHPWS_Core::initModClass('users', 'Permission.php');

    switch ($currentVersion) {
Severity: Minor
Found in boost/update.php by phpmd

The function intern_update() has a Cyclomatic Complexity of 62. The configured cyclomatic complexity threshold is 10.
Open

function intern_update(&$content, $currentVersion)
{
    PHPWS_Core::initModClass('users', 'Permission.php');

    switch ($currentVersion) {
Severity: Minor
Found in boost/update.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Missing class import via use statement (line '8', column '19').
Open

        throw new \Exception($result->toString());
Severity: Minor
Found in boost/update.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '5', column '15').
Open

    $db = new PHPWS_DB();
Severity: Minor
Found in boost/update.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PHPWS_Core' in method 'intern_update'.
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PHPWS_Core' in method 'intern_update'.
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PEAR' in method 'internRunDbMigration'.
Open

    if (PEAR::isError($result)) {
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PHPWS_Core' in method 'intern_update'.
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PHPWS_Core' in method 'intern_update'.
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Permission' in method 'intern_update'.
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PHPWS_Core' in method 'intern_update'.
Open

    PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Minor
Found in boost/update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method importFile from undeclared class \PHPWS_DB
Open

    $result = $db->importFile(PHPWS_SOURCE_DIR . 'mod/intern/boost/updates/' . $fileName);
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method isError from undeclared class \PEAR
Open

    if (PEAR::isError($result)) {
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

    PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

            PHPWS_Core::initModClass('users', 'Permission.php');
Severity: Critical
Found in boost/update.php by phan

Call to method __construct from undeclared class \PHPWS_DB
Open

    $db = new PHPWS_DB();
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Call to method registerPermissions from undeclared class \Users_Permission
Open

            Users_Permission::registerPermissions('intern', $content);
Severity: Critical
Found in boost/update.php by phan

Reference to undeclared constant \PHPWS_SOURCE_DIR
Open

    $result = $db->importFile(PHPWS_SOURCE_DIR . 'mod/intern/boost/updates/' . $fileName);
Severity: Minor
Found in boost/update.php by phan

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db = new PHPWS_DB();
Severity: Minor
Found in boost/update.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status