Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/Command/NormalCoursesRest.php

Summary

Maintainability
A
1 hr
Test Coverage

post accesses the super-global variable $_REQUEST.
Open

    public function post()
    {
        $subjectId = $_REQUEST['subjectId'];
        $cnum = $_REQUEST['cnum'];
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

post accesses the super-global variable $_REQUEST.
Open

    public function post()
    {
        $subjectId = $_REQUEST['subjectId'];
        $cnum = $_REQUEST['cnum'];
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

execute accesses the super-global variable $_SERVER.
Open

    public function execute()
    {
        switch($_SERVER['REQUEST_METHOD']) {
            case 'POST':
                $this->post();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_REQUEST.
Open

    public function delete()
    {
        $id = $_REQUEST['courseId'];
        $db = Database::newDB();
        $pdo = $db->getPDO();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method post has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function post()
    {
        $subjectId = $_REQUEST['subjectId'];
        $cnum = $_REQUEST['cnum'];
Severity: Minor
Found in class/Command/NormalCoursesRest.php - About 1 hr to fix

The method execute() contains an exit expression.
Open

                exit;
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method post() contains an exit expression.
Open

            exit;
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method post() contains an exit expression.
Open

            exit;
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method execute() contains an exit expression.
Open

                exit;
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method post() contains an exit expression.
Open

            exit;
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method execute() contains an exit expression.
Open

                exit;
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method execute() contains an exit expression.
Open

                exit;
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

Call to method newDB from undeclared class \phpws2\Database
Open

        $db = Database::newDB();
Severity: Critical
Found in class/Command/NormalCoursesRest.php by phan

Call to method newDB from undeclared class \phpws2\Database
Open

        $db = Database::newDB();
Severity: Critical
Found in class/Command/NormalCoursesRest.php by phan

Call to method newDB from undeclared class \phpws2\Database
Open

        $db = Database::newDB();
Severity: Critical
Found in class/Command/NormalCoursesRest.php by phan

Avoid using static access to class '\phpws2\Database' in method 'delete'.
Open

        $db = Database::newDB();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\phpws2\Database' in method 'post'.
Open

        $db = Database::newDB();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\phpws2\Database' in method 'get'.
Open

        $db = Database::newDB();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = Database::newDB();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = Database::newDB();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = Database::newDB();
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $_REQUEST['courseId'];
Severity: Minor
Found in class/Command/NormalCoursesRest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status