AppStateESS/InternshipInventory

View on GitHub
class/Command/ShowAddInternship.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '49', column '21').
Open

        $view = new \Intern\AddInternshipView();
Severity: Minor
Found in class/Command/ShowAddInternship.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\PHPWS_Core' in method 'execute'.
Open

            \PHPWS_Core::home();
Severity: Minor
Found in class/Command/ShowAddInternship.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\NQ' in method 'execute'.
Open

            \NQ::simple('intern', NotifyUI::ERROR, 'You do not have permission to create new internships.');
Severity: Minor
Found in class/Command/ShowAddInternship.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\NQ' in method 'execute'.
Open

            \NQ::close();
Severity: Minor
Found in class/Command/ShowAddInternship.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Current_User' in method 'execute'.
Open

        if(!\Current_User::allow('intern', 'create_internship')){
Severity: Minor
Found in class/Command/ShowAddInternship.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Possibly zero references to use statement for classlike/namespace CountryFactory (\Intern\CountryFactory)
Open

use \Intern\CountryFactory;
Severity: Minor
Found in class/Command/ShowAddInternship.php by phan

Possibly zero references to use statement for classlike/namespace State (\Intern\State)
Open

use \Intern\State;
Severity: Minor
Found in class/Command/ShowAddInternship.php by phan

Possibly zero references to use statement for classlike/namespace Department (\Intern\Department)
Open

use \Intern\Department;
Severity: Minor
Found in class/Command/ShowAddInternship.php by phan

Call to method home from undeclared class \PHPWS_Core
Open

            \PHPWS_Core::home();
Severity: Critical
Found in class/Command/ShowAddInternship.php by phan

Call to method close from undeclared class \NQ
Open

            \NQ::close();
Severity: Critical
Found in class/Command/ShowAddInternship.php by phan

Call to method simple from undeclared class \NQ
Open

            \NQ::simple('intern', NotifyUI::ERROR, 'You do not have permission to create new internships.');
Severity: Critical
Found in class/Command/ShowAddInternship.php by phan

Call to method allow from undeclared class \Current_User
Open

        if(!\Current_User::allow('intern', 'create_internship')){
Severity: Critical
Found in class/Command/ShowAddInternship.php by phan

There are no issues that match your filters.

Category
Status