Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/StudentFactory.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Intern\DataProvider\Student\StudentDataProviderFactory' in method 'getStudent'.
Open

        $provider = StudentDataProviderFactory::getProvider();
Severity: Minor
Found in class/StudentFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call with 2 arg(s) to \Intern\DataProvider\Student\StudentDataProvider::getStudent() which only takes 1 arg(s) defined at /code/class/DataProvider/Student/StudentDataProvider.php:39
Open

        return $provider->getStudent($studentId, $term);
Severity: Info
Found in class/StudentFactory.php by phan

There are no issues that match your filters.

Category
Status