AppStateESS/InternshipInventory

View on GitHub
class/SubHost.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
Severity: Major
Found in class/SubHost.php - About 1 hr to fix

Function getStreetAddress has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getStreetAddress(){
        $add = array();

        if (!empty($this->address)) {
            $add[] = $this->address . ',';
Severity: Minor
Found in class/SubHost.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method __construct has 12 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

Avoid unused local variables such as '$conditions'.
Open

        return $this->$conditions;
Severity: Minor
Found in class/SubHost.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$other_names'.
Open

        return $this->$other_names;
Severity: Minor
Found in class/SubHost.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$approve_flag'.
Open

        return $this->$approve_flag;
Severity: Minor
Found in class/SubHost.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Variable $other_names is undeclared (Did you mean $this->other_names)
Open

        return $this->$other_names;
Severity: Minor
Found in class/SubHost.php by phan

Variable $conditions is undeclared (Did you mean $this->conditions)
Open

        return $this->$conditions;
Severity: Minor
Found in class/SubHost.php by phan

Variable $approve_flag is undeclared (Did you mean $this->approve_flag)
Open

        return $this->$approve_flag;
Severity: Minor
Found in class/SubHost.php by phan

Avoid using static access to class '\Intern\SubHostFactory' in method 'getMainName'.
Open

        $main_name = SubHostFactory::getMainHostById($this->main_host_id);
Severity: Minor
Found in class/SubHost.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The property $approve_flag is not named in camelCase.
Open

class SubHost implements DbStorable {

    public $id;
    public $main_host_id;
    public $sub_name;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function setId($id){
Severity: Minor
Found in class/SubHost.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $sub_name is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $main_host_id is not named in camelCase.
Open

class SubHost implements DbStorable {

    public $id;
    public $main_host_id;
    public $sub_name;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $sub_name is not named in camelCase.
Open

class SubHost implements DbStorable {

    public $id;
    public $main_host_id;
    public $sub_name;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $main_host_id is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
Severity: Minor
Found in class/SubHost.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public $id;
Severity: Minor
Found in class/SubHost.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $approve_flag is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $other_names is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $other_names is not named in camelCase.
Open

class SubHost implements DbStorable {

    public $id;
    public $main_host_id;
    public $sub_name;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The variable $other_names is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sub_name is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $main_host_id is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $main_name is not named in camelCase.
Open

    public function getMainName(){
        $main_name = SubHostFactory::getMainHostById($this->main_host_id);
        return $main_name['host_name'];
    }
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $approve_flag is not named in camelCase.
Open

    public function __construct($id, $main_host_id, $sub_name, $address, $city, $state, $zip, $province, $country, $other_names, $conditions, $approve_flag){
        $this->id = $id;
        $this->main_host_id = $main_host_id;
        $this->sub_name = $sub_name;
        $this->address = $address;
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $main_name is not named in camelCase.
Open

    public function getMainName(){
        $main_name = SubHostFactory::getMainHostById($this->main_host_id);
        return $main_name['host_name'];
    }
Severity: Minor
Found in class/SubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status