Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/Supervisor.php

Summary

Maintainability
A
3 hrs
Test Coverage

Supervisor has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php - About 2 hrs to fix

Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
Severity: Major
Found in class/Supervisor.php - About 1 hr to fix

The method __construct has 13 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

Suspicious type null of a variable or expression used to build a string. (Expected type to be able to cast to a string)
Open

            $add[] = $this->supervisor_address . ',';
Severity: Minor
Found in class/Supervisor.php by phan

Reference to undeclared property \Intern\Supervisor->address_same_flag
Open

        return $this->address_same_flag;
Severity: Minor
Found in class/Supervisor.php by phan

Suspicious type null of a variable or expression used to build a string. (Expected type to be able to cast to a string)
Open

            $name .= $this->supervisor_first_name . " ";
Severity: Minor
Found in class/Supervisor.php by phan

Suspicious type null of a variable or expression used to build a string. (Expected type to be able to cast to a string)
Open

            $add[] = $this->supervisor_city . ', ';
Severity: Minor
Found in class/Supervisor.php by phan

Suspicious type null of a variable or expression used to build a string. (Expected type to be able to cast to a string)
Open

            $add[] = $this->supervisor_state . ' ';
Severity: Minor
Found in class/Supervisor.php by phan

Avoid excessively long variable names like $supervisor_first_name. Keep variable name length under 20.
Open

    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $supervisor_first_name. Keep variable name length under 20.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
Severity: Minor
Found in class/Supervisor.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The parameter $supervisor_last_name is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $supervisor_zip is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_province is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $supervisor_address is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $supervisor_country is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_title is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $supervisor_first_name is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_state is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function setId($id){
Severity: Minor
Found in class/Supervisor.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $supervisor_zip is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $supervisor_email is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $supervisor_province is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $host_id is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_fax is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $supervisor_phone is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $supervisor_email is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_phone is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $supervisor_state is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_first_name is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $supervisor_title is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_city is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $supervisor_country is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $host_id is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $supervisor_fax is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $supervisor_city is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $supervisor_last_name is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $supervisor_address is not named in camelCase.
Open

class Supervisor implements DbStorable {

    public $id;
    public $host_id;
    public $supervisor_first_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public $id;
Severity: Minor
Found in class/Supervisor.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The variable $supervisor_first_name is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $host_id is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_province is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_fax is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_city is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_address is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_email is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_state is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_zip is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_last_name is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_title is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_country is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $supervisor_phone is not named in camelCase.
Open

    public function __construct($supervisor_first_name, $supervisor_last_name, $supervisor_title, $supervisor_phone, $supervisor_email,
                $supervisor_fax, $supervisor_address, $supervisor_city, $supervisor_state, $supervisor_zip, $supervisor_province,
                $supervisor_country, $host_id){
        $this->supervisor_first_name = $supervisor_first_name;
        $this->supervisor_last_name = $supervisor_last_name;
Severity: Minor
Found in class/Supervisor.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status