Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/Term.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(string $term, string $description, int $availableOnTimestamp, int $censusDateTimestamp, int $startTimestamp, int $endTimestamp, int $undergradOverloadHours, int $gradOverloadHours)
Severity: Major
Found in class/Term.php - About 1 hr to fix

Avoid excessively long variable names like $undergradOverloadHours. Keep variable name length under 20.
Open

    public function __construct(string $term, string $description, int $availableOnTimestamp, int $censusDateTimestamp, int $startTimestamp, int $endTimestamp, int $undergradOverloadHours, int $gradOverloadHours)
Severity: Minor
Found in class/Term.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $census_date_timestamp. Keep variable name length under 20.
Open

    public $census_date_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $undergrad_overload_hours. Keep variable name length under 20.
Open

    public $undergrad_overload_hours;
Severity: Minor
Found in class/Term.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $available_on_timestamp. Keep variable name length under 20.
Open

    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The property $undergrad_overload_hours is not named in camelCase.
Open

class Term {

    public $term;
    public $description;
    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $semester_type is not named in camelCase.
Open

class Term {

    public $term;
    public $description;
    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $available_on_timestamp is not named in camelCase.
Open

class Term {

    public $term;
    public $description;
    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $grad_overload_hours is not named in camelCase.
Open

class Term {

    public $term;
    public $description;
    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $census_date_timestamp is not named in camelCase.
Open

class Term {

    public $term;
    public $description;
    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $end_timestamp is not named in camelCase.
Open

class Term {

    public $term;
    public $description;
    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $start_timestamp is not named in camelCase.
Open

class Term {

    public $term;
    public $description;
    public $available_on_timestamp;
Severity: Minor
Found in class/Term.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status