Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/UI/NotifyUI.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\NQ' in method 'display'.
Open

        $notifications = \NQ::popAll('intern');
Severity: Minor
Found in class/UI/NotifyUI.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\PHPWS_Template' in method 'display'.
Open

        $content = \PHPWS_Template::process($tags, 'intern', 'notification.tpl');
Severity: Minor
Found in class/UI/NotifyUI.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Saw unextractable annotation for comment '* @return - Properly styled notifications.'
Open

     * @return - Properly styled notifications.
Severity: Info
Found in class/UI/NotifyUI.php by phan

Call to method process from undeclared class \PHPWS_Template
Open

        $content = \PHPWS_Template::process($tags, 'intern', 'notification.tpl');
Severity: Critical
Found in class/UI/NotifyUI.php by phan

Parameter $n has undeclared type \Notification
Open

    private static function getType(\Notification $n)
Severity: Minor
Found in class/UI/NotifyUI.php by phan

Call to method popAll from undeclared class \NQ
Open

        $notifications = \NQ::popAll('intern');
Severity: Critical
Found in class/UI/NotifyUI.php by phan

Call to method getType from undeclared class \Notification
Open

        switch($n->getType()){
Severity: Critical
Found in class/UI/NotifyUI.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

\PHPWS_Core::initModClass('notification', 'NQ.php');
Severity: Critical
Found in class/UI/NotifyUI.php by phan

Avoid variables with short names like $n. Configured minimum length is 3.
Open

    private static function getType(\Notification $n)
Severity: Minor
Found in class/UI/NotifyUI.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status