Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/WorkflowStateFactory.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '30', column '23').
Open

            throw new \InvalidArgumentException('Missing state name.');
Severity: Minor
Found in class/WorkflowStateFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\PHPWS_Core' in method 'getAllStates'.
Open

                \PHPWS_Core::initModClass('intern', self::$dir . '/' . $f);
Severity: Minor
Found in class/WorkflowStateFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private methods such as 'sortStates'.
Open

    private static function sortStates(WorkflowState $a, WorkflowState $b)
    {
        if($a->getSortIndex() == $b->getSortIndex()){
            return 0;
        }
Severity: Minor
Found in class/WorkflowStateFactory.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Reference to undeclared constant \PHPWS_SOURCE_DIR
Open

        $dir = PHPWS_SOURCE_DIR . 'mod/intern/class/' . self::$dir;
Severity: Minor
Found in class/WorkflowStateFactory.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

                \PHPWS_Core::initModClass('intern', self::$dir . '/' . $f);
Severity: Critical
Found in class/WorkflowStateFactory.php by phan

Avoid variables with short names like $b. Configured minimum length is 3.
Open

    private static function sortStates(WorkflowState $a, WorkflowState $b)
Severity: Minor
Found in class/WorkflowStateFactory.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $a. Configured minimum length is 3.
Open

    private static function sortStates(WorkflowState $a, WorkflowState $b)
Severity: Minor
Found in class/WorkflowStateFactory.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status