Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/WorkflowTransition/LeaveTransition.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$i'.
Open

    public function allowed(Internship $i){
Severity: Minor
Found in class/WorkflowTransition/LeaveTransition.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid variables with short names like $i. Configured minimum length is 3.
Open

    public function allowed(Internship $i){
Severity: Minor
Found in class/WorkflowTransition/LeaveTransition.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Constant destState should be defined in uppercase
Open

    const destState   = null;
Severity: Minor
Found in class/WorkflowTransition/LeaveTransition.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sortIndex should be defined in uppercase
Open

    const sortIndex = 0;
Severity: Minor
Found in class/WorkflowTransition/LeaveTransition.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sourceState should be defined in uppercase
Open

    const sourceState = '*';
Severity: Minor
Found in class/WorkflowTransition/LeaveTransition.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

There are no issues that match your filters.

Category
Status