Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/WorkflowTransition/RegistrationIssueToDean.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Current_User' in method 'allowed'.
Open

            if(\Current_User::allow('intern', 'distance_ed_register')){
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method allowed uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        }else{
            return parent::allowed($i);
        }
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method allowed uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            }else{
                return false;
            }
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Call to method allow from undeclared class \Current_User
Open

            if(\Current_User::allow('intern', 'distance_ed_register')){
Severity: Critical
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phan

Avoid variables with short names like $i. Configured minimum length is 3.
Open

    public function allowed(Internship $i)
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Constant sourceState should be defined in uppercase
Open

    const sourceState = 'RegistrationIssueState';
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant destState should be defined in uppercase
Open

    const destState   = 'SigAuthApprovedState';
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sortIndex should be defined in uppercase
Open

    const sortIndex = 6;
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant actionName should be defined in uppercase
Open

    const actionName  = 'Return for Dean Approval';
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

There are no issues that match your filters.

Category
Status