Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
contrib/importHost.php

Summary

Maintainability
A
0 mins
Test Coverage

The method createHost uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

      }else{
          return $id;
      }
Severity: Minor
Found in contrib/importHost.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Suspicious array access to nullable ?array|null|string[]
Open

    $values = $line[0];
Severity: Minor
Found in contrib/importHost.php by phan

Argument 2 (newvalue) is 2 but \ini_set() takes string
Open

ini_set('ERROR_REPORTING', E_WARNING);
Severity: Minor
Found in contrib/importHost.php by phan

Argument 2 (newvalue) is 1 but \ini_set() takes string
Open

ini_set('display_errors', 1);
Severity: Minor
Found in contrib/importHost.php by phan

Avoid variables with short names like $id. Configured minimum length is 3.
Open

      $id = $id_result[0];
Severity: Minor
Found in contrib/importHost.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The variable $id_result is not named in camelCase.
Open

function createHost($name){
    $query = "SELECT NEXTVAL('intern_host_seq')";
    $id_result = pg_query($query);

    // create new host
Severity: Minor
Found in contrib/importHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_result is not named in camelCase.
Open

function createHost($name){
    $query = "SELECT NEXTVAL('intern_host_seq')";
    $id_result = pg_query($query);

    // create new host
Severity: Minor
Found in contrib/importHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_result is not named in camelCase.
Open

function createHost($name){
    $query = "SELECT NEXTVAL('intern_host_seq')";
    $id_result = pg_query($query);

    // create new host
Severity: Minor
Found in contrib/importHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_result is not named in camelCase.
Open

function createHost($name){
    $query = "SELECT NEXTVAL('intern_host_seq')";
    $id_result = pg_query($query);

    // create new host
Severity: Minor
Found in contrib/importHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_result is not named in camelCase.
Open

function createHost($name){
    $query = "SELECT NEXTVAL('intern_host_seq')";
    $id_result = pg_query($query);

    // create new host
Severity: Minor
Found in contrib/importHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status