Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star

Showing 6,675 of 6,675 total issues

get accesses the super-global variable $_REQUEST.
Open

    public function get()
    {
        $db = \phpws2\Database::newDB();
        $pdo = $db->getPDO();
Severity: Minor
Found in class/Command/AffiliateListRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

post accesses the super-global variable $_REQUEST.
Open

    public function post()
    {
        $dept = $_REQUEST['create'];

        if ($dept == '')
Severity: Minor
Found in class/Command/DeptRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

put accesses the super-global variable $_REQUEST.
Open

    public function put()
    {
        $db = Database::newDB();
        $pdo = $db->getPDO();
Severity: Minor
Found in class/Command/DeptRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

post accesses the super-global variable $_REQUEST.
Open

    public function post()
    {
        $deptId = $_REQUEST['department'];
        $affiliationId = $_REQUEST['affiliation_agreement_id'];
Severity: Minor
Found in class/Command/AffiliateDeptRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_REQUEST.
Open

    public function delete()
    {
        $deptId = $_REQUEST['department'];
        $affiliationId = $_REQUEST['affiliation_agreement_id'];
Severity: Minor
Found in class/Command/AffiliateDeptRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

post accesses the super-global variable $_REQUEST.
Open

    public function post()
    {
        // Check permissions
        if(!\Current_User::isLogged()){
            header('HTTP/1.1 403 Forbidden');
Severity: Minor
Found in class/Command/EmergencyContactRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_REQUEST.
Open

    public function delete()
    {
        $deptId = $_REQUEST['department'];
        $affiliationId = $_REQUEST['affiliation_agreement_id'];
Severity: Minor
Found in class/Command/AffiliateDeptRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

execute accesses the super-global variable $_SERVER.
Open

    public function execute()
    {
        /* Check if user should have access to affiliation data*/
        if(!\Current_User::isLogged()){
            \NQ::simple('intern', \Intern\UI\NotifyUI::WARNING, 'You do not have permission to affiliation agreement.');
Severity: Minor
Found in class/Command/AgreementTypeRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

put accesses the super-global variable $_REQUEST.
Open

    public function put()
    {
        $db = Database::newDB();
        $pdo = $db->getPDO();
Severity: Minor
Found in class/Command/DeptRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

put accesses the super-global variable $_REQUEST.
Open

    public function put()
    {
        $db = Database::newDB();
        $pdo = $db->getPDO();
Severity: Minor
Found in class/Command/DeptRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

post accesses the super-global variable $_REQUEST.
Open

    public function post($contractDir, $otherDir, $affiliationDir)
    {
        // List of known types taken from fileca$target_dir = $otherDir;binet. Only these accepted, update list of accept more.
        $known_documents = array('csv', 'doc', 'docx', 'odt', 'pdf', 'ppt', 'pptx', 'rtf',
            'tar', 'tgz', 'txt', 'xls', 'xlsx', 'xml', 'zip', 'gz', 'rar', 'ods', 'odp');
Severity: Minor
Found in class/Command/DocumentRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

get accesses the super-global variable $_REQUEST.
Open

    public function get()
    {
        $id = $_REQUEST['id'];
        $type = $_REQUEST['type'];
        // If the document's id is set then we're downloading the file
Severity: Minor
Found in class/Command/DocumentRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

execute accesses the super-global variable $_SERVER.
Open

    public function execute()
    {

        switch($_SERVER['REQUEST_METHOD']) {
            case 'DELETE':
Severity: Minor
Found in class/Command/EmergencyContactRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

post accesses the super-global variable $_REQUEST.
Open

    public function post()
    {
        // Check permissions
        if(!\Current_User::isLogged()){
            header('HTTP/1.1 403 Forbidden');
Severity: Minor
Found in class/Command/EmergencyContactRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

execute accesses the super-global variable $_REQUEST.
Open

    public function execute()
    {
        $searchString = $_REQUEST['searchString'];

        // If there was no search string, return an empty array to avoid front-end errors
Severity: Minor
Found in class/Command/GetSearchSuggestions.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

post accesses the super-global variable $_REQUEST.
Open

    public function post() {
        $Name = $_REQUEST['name'];
        $db = PdoFactory::getPdoInstance();

        if(isset($_REQUEST['admin'])){
Severity: Minor
Found in class/Command/HostRest.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

execute accesses the super-global variable $_REQUEST.
Open

    public function execute()
    {
        /* Check if user should have access to Affiliate Agreement page */
        if(!\Current_User::allow('intern', 'affiliation_agreement')){
            \NQ::simple('intern', \Intern\UI\NotifyUI::WARNING, 'You do not have permission to add Affiliation Agreements.');
Severity: Minor
Found in class/Command/SaveAffiliate.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

execute accesses the super-global variable $_REQUEST.
Open

    public function execute()
    {
        /* Check if user should have access to Affiliate Agreement page */
        if(!\Current_User::allow('intern', 'affiliation_agreement')){
            \NQ::simple('intern', \Intern\UI\NotifyUI::WARNING, 'You do not have permission to add Affiliation Agreements.');
Severity: Minor
Found in class/Command/SaveAffiliate.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

execute accesses the super-global variable $_POST.
Open

    public function execute() {
        // Check permissions
        if(!\Current_User::allow('intern', 'create_internship')){
            \NQ::simple('intern', \Intern\UI\NotifyUI::ERROR, 'You do not have permission to create new internships.');
            \NQ::close();
Severity: Minor
Found in class/Command/AddInternship.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

checkForMissingInput accesses the super-global variable $_POST.
Open

    private function checkForMissingInput() {
        // Check for missing data
        $missingFieldList = array();

        // Check student ID
Severity: Minor
Found in class/Command/AddInternship.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Severity
Category
Status
Source
Language