Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star

Showing 6,675 of 6,675 total issues

Constant sourceState should be defined in uppercase
Open

    const sourceState = 'RegisteredState';
Severity: Minor
Found in class/WorkflowTransition/UndoUndergradRegistration.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant actionName should be defined in uppercase
Open

    const actionName  = 'Mark as Not Registered';
Severity: Minor
Found in class/WorkflowTransition/UndoUndergradRegistration.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant actionName should be defined in uppercase
Open

    const actionName  = 'Mark as Grad School Approved';
Severity: Minor
Found in class/WorkflowTransition/GradSchoolApprove.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sourceState should be defined in uppercase
Open

    const sourceState = 'SigAuthReadyState';
Severity: Minor
Found in class/WorkflowTransition/SigAuthApprove.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant actionName should be defined in uppercase
Open

    const actionName  = 'Return for Dean Approval';
Severity: Minor
Found in class/WorkflowTransition/UndoDeanApprove.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant destState should be defined in uppercase
Open

    const destState   = 'DeanApprovedState';
Severity: Minor
Found in class/WorkflowTransition/UndoGradSchoolApproval.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sortIndex should be defined in uppercase
Open

    const sortIndex = 6;
Severity: Minor
Found in class/WorkflowTransition/UndoGradSchoolApproval.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sourceState should be defined in uppercase
Open

    const sourceState = 'RegisteredState';
Severity: Minor
Found in class/WorkflowTransition/UndoGraduateRegistration.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sourceState should be defined in uppercase
Open

    const sourceState = 'NewState';
Severity: Minor
Found in class/WorkflowTransition/DepartmentApprove.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant destState should be defined in uppercase
Open

    const destState   = 'RegisteredState';
Severity: Minor
Found in class/WorkflowTransition/RegisterAfterIssue.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant actionName should be defined in uppercase
Open

    const actionName  = 'Return for Dean Approval';
Severity: Minor
Found in class/WorkflowTransition/RegistrationIssueToDean.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant sourceState should be defined in uppercase
Open

    const sourceState = 'CancelledState';
Severity: Minor
Found in class/WorkflowTransition/Reinstate.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant destState should be defined in uppercase
Open

    const destState   = 'NewState';
Severity: Minor
Found in class/WorkflowTransition/Reinstate.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

checkRequiredFields accesses the super-global variable $_POST.
Open

    public function checkRequiredFields(Internship $i){
        $emergName = $i->getEmergencyContactName();
        if(!isset($emergName)){
            throw new MissingDataException("Please add an emergency contact.");
        }
Severity: Minor
Found in class/WorkflowTransition/SigAuthApprove.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Constant sourceState should be defined in uppercase
Open

    const sourceState = 'GradSchoolApprovedState';
Severity: Minor
Found in class/WorkflowTransition/UndoGradSchoolApproval.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Adjoining classes: .tt-suggestion.tt-cursor
Open

.tt-suggestion.tt-cursor {
Severity: Minor
Found in templates/style.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

#small-button1 {
Severity: Minor
Found in templates/style.css by csslint

Unknown property 'overflowY'.
Open

    overflowY: 'scroll';
Severity: Minor
Found in templates/style.css by csslint

Unknown property 'overscroll-behavior'.
Open

    overscroll-behavior: auto;
Severity: Minor
Found in templates/style.css by csslint

Heading (h3) should not be qualified.
Open

#changelog h3 {
Severity: Minor
Found in templates/style.css by csslint
Severity
Category
Status
Source
Language