Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star

Showing 6,675 of 6,675 total issues

The variable $student_default is not named in camelCase.
Open

function print_help()
{
    $student_default = NUMBER_OF_STUDENTS;
    echo <<<EOF
Populates the intern_local_student_data table with fake student info for testing.
Severity: Minor
Found in contrib/createFakeStudents.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $first_name is not named in camelCase.
Open

function username($last_name, $first_name)
{
    static $all_usernames = array();
    $username = strtolower(substr($last_name, 0, 6) . substr($first_name, 0, 2));
    if (in_array($username, $all_usernames)) {
Severity: Minor
Found in contrib/createFakeStudents.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $first_name is not named in camelCase.
Open

function pref_name($first_name)
{
    $chance = mt_rand(1, 100);
    if ($chance <= NICKNAME_CHANCE) {
        return nickname($first_name);
Severity: Minor
Found in contrib/createFakeStudents.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_result is not named in camelCase.
Open

function createSubHost($db, $values){
    $query = "SELECT NEXTVAL('intern_sub_host_seq')";
    $id_result = pg_query($query);

    // create new sub host
Severity: Minor
Found in contrib/importSubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_result is not named in camelCase.
Open

function createSubHost($db, $values){
    $query = "SELECT NEXTVAL('intern_sub_host_seq')";
    $id_result = pg_query($query);

    // create new sub host
Severity: Minor
Found in contrib/importSubHost.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _getJoinOn is not named in camelCase.
Open

    public function _getJoinOn($join_on_1, $join_on_2, $table1, $table2, $ignore_tables = false)
    {
        if (empty($join_on_1) || empty($join_on_2)) {
            return null;
        }
Severity: Minor
Found in class/SubselectDatabase.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _updateCurrent is not named in camelCase.
Open

    public static function _updateCurrent($key)
    {
        $GLOBALS['PHPWS_DB']['lib'] = $GLOBALS['PHPWS_DB']['dbs'][$key]['lib'];
        $GLOBALS['PHPWS_DB']['dsn'] = & $GLOBALS['PHPWS_DB']['dbs'][$key]['dsn'];
        $GLOBALS['PHPWS_DB']['connection'] = $GLOBALS['PHPWS_DB']['dbs'][$key]['connection'];
Severity: Minor
Found in class/SubselectDatabase.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _indexBy is not named in camelCase.
Open

    public function _indexBy($sql, $indexby, $colMode = false)
    {
        $rows = array();

        if (!is_array($sql) || empty($sql)) {
Severity: Minor
Found in class/SubselectDatabase.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _expandIndex is not named in camelCase.
Open

    public function _expandIndex(&$rows, $index, $item, &$stacked)
    {
        if ($this->force_array) {
            $rows[$index][] = $item;
        } elseif (isset($rows[$index]) && !$this->ignore_dups) {
Severity: Minor
Found in class/SubselectDatabase.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

TODO found
Open

    // TODO: this should return the table of affiliation agreement objects
Severity: Minor
Found in class/Command/AffiliateListRest.php by fixme

TODO found
Open

    // TODO: this should return the whole affiliation agreement object
Severity: Minor
Found in class/Command/AffiliateRest.php by fixme

TODO found
Open

        //TODO: Use a single $params array instead of making a new array for every call to PHPWS_Test::moduleLink
Severity: Minor
Found in class/Internship.php by fixme

TODO found
Open

-- TODO: Drop faculty_supervisor_id column from intern_internship table
Severity: Minor
Found in boost/updates/update_00.01.05.sql by fixme

TODO found
Open

        // TODO: Maybe be smarter about which result we use?
Severity: Minor
Found in class/DataProvider/Student/WebServiceDataProvider.php by fixme

TODO found
Open

        // TODO - only works for students right now
Severity: Minor
Found in class/DataProvider/Student/LocalDbStudentDataProvider.php by fixme

TODO found
Open

            // TODO: show an error alert for invalid format (banner ID must be nine digits)
Severity: Minor
Found in javascript/facultyEdit/FacultyEdit.jsx by fixme

TODO found
Open

        // TODO: this will break if you have more than one db pager at a time
Severity: Minor
Found in class/SubselectPager.php by fixme

TODO found
Open

// TODO: some sort of command pattern
Severity: Minor
Found in index.php by fixme

TODO found
Open

        // TODO: use a regular exp to make sure it's nine digits, not just nine characters
Severity: Minor
Found in javascript/facultyEdit/FacultyEdit.jsx by fixme

TODO found
Open

    $username = $line[6]; //TODO
Severity: Minor
Found in contrib/importAutosuggest.php by fixme
Severity
Category
Status
Source
Language