Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
javascript/affiliationAgreement/AffiliationUpload.jsx

Summary

Maintainability
F
1 wk
Test Coverage

Function render has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render(){
        let list
        if (this.state.currentFiles.length > 0) {
            list = this.state.currentFiles.map(function(f){
                let url = "index.php?module=intern&action=documentRest&type=affiliation&docId="+f.id+"&id="+this.props.affiliationId;
Severity: Minor
Found in javascript/affiliationAgreement/AffiliationUpload.jsx - About 1 hr to fix

Function addFiles has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    addFiles(files){
        let currentfiles = [];
        // Sends a seperate request for each file uploaded since there can be multiple at once
        $.each(files, function (key, value) {
            let formData = new FormData();
Severity: Minor
Found in javascript/affiliationAgreement/AffiliationUpload.jsx - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class AffiliationUploadInfo extends React.Component{
    constructor(props) {
        super(props)
        this.state = {currentFiles: []}
        this.addFiles = this.addFiles.bind(this);
Severity: Major
Found in javascript/affiliationAgreement/AffiliationUpload.jsx and 1 other location - About 1 wk to fix
javascript/otherDocuments/OtherDocuments.jsx on lines 6..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1241.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status