Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
javascript/manager/Manager.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        var data = null
        var description = null
        if (this.state.mainData != null) {
            var onHidden = this.onHidden;
Severity: Major
Found in javascript/manager/Manager.jsx - About 2 hrs to fix

Function render has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        var name = null;
        var hButton = null;
        // Determines which element to show on the page (hide/show and Save/Edit)
        if (this.props.hidden === 0) {
Severity: Minor
Found in javascript/manager/Manager.jsx - About 1 hr to fix

Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        return (
            <div className="col-md-5 col-md-offset-1">
                <br /><br /><br />
                <div className="panel panel-default">
Severity: Minor
Found in javascript/manager/Manager.jsx - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $.ajax({
            url: 'index.php?module=intern&action='+this.props.ajaxURL,
            type: 'GET',
            dataType: 'json',
            success: function(data) {
Severity: Major
Found in javascript/manager/Manager.jsx and 1 other location - About 4 hrs to fix
javascript/emergencyContact/EmgContactList.jsx on lines 245..256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            <div id="success" className="alert alert-success alert-dismissible" role="alert" hidden>
                <button type="button"  className="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
                <strong>Success!</strong> {this.state.success}
            </div>
Severity: Major
Found in javascript/manager/Manager.jsx and 4 other locations - About 3 hrs to fix
javascript/editLevel/editLevel.jsx on lines 213..216
javascript/editLevel/editLevel.jsx on lines 218..221
javascript/facultyEdit/FacultyEdit.jsx on lines 582..585
javascript/manager/Manager.jsx on lines 250..253

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            <div id="warningError" className="alert alert-warning alert-dismissible" role="alert" hidden>
                <button type="button"  className="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
                <strong>Warning!</strong> {this.state.errorWarning}
            </div>
Severity: Major
Found in javascript/manager/Manager.jsx and 4 other locations - About 3 hrs to fix
javascript/editLevel/editLevel.jsx on lines 213..216
javascript/editLevel/editLevel.jsx on lines 218..221
javascript/facultyEdit/FacultyEdit.jsx on lines 582..585
javascript/manager/Manager.jsx on lines 245..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    constructor(props) {
        super(props);
        this.state = {
            editMode: false
        };
Severity: Major
Found in javascript/manager/Manager.jsx and 3 other locations - About 3 hrs to fix
javascript/specialHost/ApproveHost.jsx on lines 386..393
javascript/specialHost/ApproveHost.jsx on lines 432..439
javascript/specialHost/ApproveHost.jsx on lines 471..478

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status