Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/Command/AssignStudentCommand.php

Summary

Maintainability
C
1 day
Test Coverage

Function execute has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        if(!UserStatus::isAdmin() || !\Current_User::allow('hms', 'assignment_maintenance')){
            throw new PermissionException('You do not have permission to assign students.');
        }
Severity: Minor
Found in class/Command/AssignStudentCommand.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        if(!UserStatus::isAdmin() || !\Current_User::allow('hms', 'assignment_maintenance')){
            throw new PermissionException('You do not have permission to assign students.');
        }
Severity: Major
Found in class/Command/AssignStudentCommand.php - About 4 hrs to fix

Function sendContract has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function sendContract(Student $student, HousingApplication $housingApplication = null, $term)
    {
        // Decide which envelope template to use based on student's age
        if($student->isUnder18()){
            // Look up the student's application (if any) and try to pull parent/guardian info from the application before failing to send
Severity: Minor
Found in class/Command/AssignStudentCommand.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRequestVars has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRequestVars()
    {
        $vars = array('action'=>'AssignStudent');

        if(isset($this->username)){
Severity: Minor
Found in class/Command/AssignStudentCommand.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status