Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/Command/SubmitRLCReapplicationPageOneCommand.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function execute has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        $term = $context->get('term');
        $student = StudentFactory::getStudentByUsername(UserStatus::getUsername(), $term);
Severity: Minor
Found in class/Command/SubmitRLCReapplicationPageOneCommand.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        $term = $context->get('term');
        $student = StudentFactory::getStudentByUsername(UserStatus::getUsername(), $term);
Severity: Major
Found in class/Command/SubmitRLCReapplicationPageOneCommand.php - About 2 hrs to fix

Consider simplifying this complex logical expression.
Open

            if((isset($rlcChoice2) && $rlcChoice1 == $rlcChoice2) || (isset($rlcChoice2) && isset($rlcChoice3) && $rlcChoice2 == $rlcChoice3) || (isset($rlcChoice3) && $rlcChoice1 == $rlcChoice3)){
                \NQ::simple('hms', NotificationView::ERROR, 'You cannot choose the same community twice.');
                $formCmd->redirect();
            }
Severity: Major
Found in class/Command/SubmitRLCReapplicationPageOneCommand.php - About 1 hr to fix

There are no issues that match your filters.

Category
Status