Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/Report/EarlyRelease/EarlyRelease.php

Summary

Maintainability
C
1 day
Test Coverage

Function execute has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute()
    {
        $db = PdoFactory::getPdoInstance();

        $query = 'SELECT hms_new_application.username, hms_new_application.banner_id, hms_lottery_application.early_release FROM hms_new_application JOIN hms_lottery_application ON hms_new_application.id = hms_lottery_application.id WHERE (hms_new_application.term = :term AND hms_lottery_application.early_release IS NOT NULL) ORDER BY hms_lottery_application.early_release ASC, hms_new_application.username ASC';
Severity: Minor
Found in class/Report/EarlyRelease/EarlyRelease.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute()
    {
        $db = PdoFactory::getPdoInstance();

        $query = 'SELECT hms_new_application.username, hms_new_application.banner_id, hms_lottery_application.early_release FROM hms_new_application JOIN hms_lottery_application ON hms_new_application.id = hms_lottery_application.id WHERE (hms_new_application.term = :term AND hms_lottery_application.early_release IS NOT NULL) ORDER BY hms_lottery_application.early_release ASC, hms_new_application.username ASC';
Severity: Major
Found in class/Report/EarlyRelease/EarlyRelease.php - About 2 hrs to fix

There are no issues that match your filters.

Category
Status