AppStateESS/homestead

View on GitHub
class/Report/PackageDeskExport/PackageDeskExport.php

Summary

Maintainability
A
1 hr
Test Coverage

Method execute has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute()
    {
        $this->data = array();

        $query = "SELECT hms_assignment.id, hms_assignment.banner_id, hms_assignment.asu_username, hms_new_application.cell_phone, hms_room.room_number, hms_floor.floor_number, hms_residence_hall.hall_name FROM hms_assignment LEFT JOIN (SELECT username, MAX(term) AS mterm FROM hms_new_application GROUP BY username) AS a ON hms_assignment.asu_username = a.username LEFT JOIN hms_new_application ON a.username = hms_new_application.username AND a.mterm = hms_new_application.term LEFT JOIN hms_bed ON hms_assignment.bed_id = hms_bed.id LEFT JOIN hms_room ON hms_bed.room_id = hms_room.id LEFT JOIN hms_floor ON hms_room.floor_id = hms_floor.id LEFT JOIN hms_residence_hall ON hms_floor.residence_hall_id = hms_residence_hall.id WHERE ( hms_assignment.term = $this->term) ORDER BY hms_residence_hall.id ASC";
Severity: Minor
Found in class/Report/PackageDeskExport/PackageDeskExport.php - About 1 hr to fix

There are no issues that match your filters.

Category
Status