Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/Room.php

Summary

Maintainability
F
4 days
Test Coverage

File Room.php has 654 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Homestead;

use \Homestead\Exception\DatabaseException;
Severity: Major
Found in class/Room.php - About 1 day to fix

Room has 61 functions (exceeds 20 allowed). Consider refactoring.
Open

class Room extends HMS_Item
{

    public $term;
    public $floor_id               = 0;
Severity: Major
Found in class/Room.php - About 1 day to fix

Function copy has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function copy($to_term, $floor_id, $suite_id=NULL, $assignments = false)
    {
        if (!$this->id) {
            return false;
        }
Severity: Minor
Found in class/Room.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_row_edit has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_row_edit() {
        javascript('jquery');
        $tpl = array();
        $tpl['ID']           = $this->id;
        $tpl['ROOM_NUMBER']  = \PHPWS_Text::secureLink($this->room_number, 'hms', array('action'=>'EditRoomView', 'room'=>$this->id));
Severity: Major
Found in class/Room.php - About 2 hrs to fix

Method copy has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function copy($to_term, $floor_id, $suite_id=NULL, $assignments = false)
    {
        if (!$this->id) {
            return false;
        }
Severity: Minor
Found in class/Room.php - About 1 hr to fix

Function can_change_gender has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function can_change_gender($target_gender, $ignore_upper = false)
    {
        // Ignore upper is true, we're trying to change a hall/floor
        if ($ignore_upper) {
            // If ignore upper is true and the target gender coed, then we
Severity: Minor
Found in class/Room.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deleteRoom has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static function deleteRoom($roomId)
    {

        if (!\Current_User::allow('hms', 'room_structure')) {
            throw new PermissionException('You do not have permission to delete a room.');
Severity: Minor
Found in class/Room.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method listReserveReasons has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function listReserveReasons()
    {
        $athletics[] = array('NAME' => 'Football', 'VALUE' => 'football');
        $athletics[] = array('NAME' => 'Basketball', 'VALUE' => 'basketball');
        $athletics[] = array('NAME' => 'Baseball', 'VALUE' => 'baseball');
Severity: Minor
Found in class/Room.php - About 1 hr to fix

Method get_row_tags has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_row_tags()
    {
        $tpl = array();

        $tpl['ID']             = $this->id;
Severity: Minor
Found in class/Room.php - About 1 hr to fix

Function has_vacancy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function has_vacancy()
    {
        $num_assigned = $this->get_number_of_assignees();

        // If this is a private room, then this room is full if one person is assigned
Severity: Minor
Found in class/Room.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_assignees has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function get_assignees()
    {
        if (!$this->loadBeds()) {
            return false;
        }
Severity: Minor
Found in class/Room.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getBedsWithVacancies has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getBedsWithVacancies()
    {
        if (!$this->loadBeds()) {
            return false;
        }
Severity: Minor
Found in class/Room.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in class/Room.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return true;
Severity: Major
Found in class/Room.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in class/Room.php - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function delete()
    {
        if (is_null($this->id) || !isset($this->id)) {
            throw new \InvalidArgumentException('Invalid room id.');
        }
Severity: Major
Found in class/Room.php and 1 other location - About 1 hr to fix
class/Bed.php on lines 202..217

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (\Current_User::allow('hms','room_structure') && $this->get_number_of_assignees() == 0) {
            $deleteRoomCmd = CommandFactory::getCommand('DeleteRoom');
            $deleteRoomCmd->setRoomId($this->id);
            $deleteRoomCmd->setFloorId($this->floor_id);
Severity: Major
Found in class/Room.php and 1 other location - About 1 hr to fix
class/Bed.php on lines 316..326

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getLink($prependText = NULL)
    {
        $roomCmd = CommandFactory::getCommand('EditRoomView');
        $roomCmd->setRoomId($this->id);
        if (!is_null($prependText)) {
Severity: Minor
Found in class/Room.php and 1 other location - About 30 mins to fix
class/Floor.php on lines 147..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status