Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/RoomChangeRequestStudentApprovalView.php

Summary

Maintainability
A
1 hr
Test Coverage

Method show has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function show()
    {
        $approveCmd = CommandFactory::getCommand('RoomChangeStudentApprove');
        $approveCmd->setParticipantId($this->thisParticipant->getId());
        $approveCmd->setRequestId($this->request->getId());
Severity: Minor
Found in class/RoomChangeRequestStudentApprovalView.php - About 1 hr to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(Student $student, RoomChangeRequest $request, Array $participants, RoomChangeParticipant $thisParticipant, $term)
Severity: Minor
Found in class/RoomChangeRequestStudentApprovalView.php - About 35 mins to fix

There are no issues that match your filters.

Category
Status