Sign upLogin

AppStateESS/homestead

View on GitHub
Star

Showing 1,397 of 1,397 total issues

Function SourceNode_fromStringWithSourceMap has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function SourceNode_fromStringWithSourceMap(aGeneratedCode, aSourceMapConsumer) {
      // The SourceNode we want to fill with the generated code
      // and the SourceMap
      var node = new SourceNode();
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 2 hrs to fix

File ApplicationFeature.php has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Homestead;

use \Homestead\Exception\DatabaseException;
Severity: Minor
Found in class/ApplicationFeature.php - About 2 hrs to fix

Function scanNumericLiteral has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function scanNumericLiteral() {
        var number, start, ch;

        ch = source[index];
        assert(isDecimalDigit(ch.charCodeAt(0)) || (ch === '.'),
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 2 hrs to fix

Function SourceNode_toStringWithSourceMap has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  SourceNode.prototype.toStringWithSourceMap = function SourceNode_toStringWithSourceMap(aArgs) {
    var generated = {
      code: "",
      line: 1,
      column: 0
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 2 hrs to fix

Function render has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        var options = Array({category:"Welcome", id: 0, description: "Select the type of damage"});//{id: 0, description: "Select the type of Damage"}
        var data = this.props.options;

        for(var i = 0; i < data.length; i++){
Severity: Major
Found in javascript/RoomDamages/RoomDamages.jsx - About 2 hrs to fix

Method show has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function show()
    {
        if (!UserStatus::isAdmin() || !\Current_User::allow('hms', 'bed_view')) {
            throw new PermissionException('You are not allowed to edit or view beds.');
        }
Severity: Major
Found in class/BedView.php - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function setHousingWaiver($username, $term)
    {
        $params = array(
                        'StudentID'=>$username,
                        'TermCode'=>$term);
Severity: Major
Found in util/SOAP.php and 1 other location - About 2 hrs to fix
util/SOAP.php on lines 195..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function clearHousingWaiver($username, $term)
    {
        $params = array(
                        'StudentID'=>$username,
                        'TermCode'=>$term);
Severity: Major
Found in util/SOAP.php and 1 other location - About 2 hrs to fix
util/SOAP.php on lines 174..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function sendInvites has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function sendInvites()
    {
        HMS_Activity_Log::log_activity('hms', ACTIVITY_LOTTERY_EXECUTED, 'hms');
        $this->output[] = "Lottery system invoked on " . date("d M, Y @ g:i:s", $this->now) . " ($this->now)";
Severity: Minor
Found in class/LotteryProcess.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        $term = $context->get('term');
        $username = UserStatus::getUsername();
Severity: Minor
Found in class/Command/HousingApplicationConfirmCommand.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        // Check permissions
        if (!\Current_User::allow('hms', 'checkin')) {
            throw new PermissionException('You do not have permission to checkin students.');
Severity: Minor
Found in class/Command/CheckoutFormSubmitCommand.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function plugSOAPData has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private static function plugSOAPData(&$student, $soapData)
    {
        $student->setBannerId($soapData->banner_id);
        $student->setUsername($soapData->user_name);
Severity: Minor
Found in class/SOAPDataProvider.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

     public function execute(CommandContext $context)
    {
        if (!UserStatus::isAdmin() || !\Current_User::allow('hms', 'hall_attributes') ) {
            throw new PermissionException('You do not have permission to edit halls.');
        }
Severity: Minor
Found in class/Command/EditResidenceHallCommand.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct()
    {
        parent::__construct();
        if(UserStatus::isAdmin()){
            if(\Current_User::allow('hms', 'assignment_maintenance')){
Severity: Minor
Found in class/AssignmentMenu.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getHMS has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getHMS()
    {
        $rh = getallheaders();

        if (isset(HMSFactory::$hms)) {
Severity: Minor
Found in class/HMSFactory.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function show has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function show()
    {
        if(!UserStatus::isAdmin() || !\Current_User::allow('hms', 'floor_view')){
            throw new PermissionException('You are not allowed to edit or view floors.');
        }
Severity: Minor
Found in class/FloorView.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SourceMapConsumer_parseMappings has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function SourceMapConsumer_parseMappings(aStr, aSourceRoot) {
      var generatedLine = 1;
      var previousGeneratedColumn = 0;
      var previousOriginalLine = 0;
      var previousOriginalColumn = 0;
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 2 hrs to fix

Function addOption has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

$.fn.addOption = function()
{
    var add = function(el, v, t, sO)
    {
        var option = document.createElement("option");
Severity: Major
Found in javascript/jquery.selectboxes.js - About 2 hrs to fix

Method sendInvites has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendInvites()
    {
        HMS_Activity_Log::log_activity('hms', ACTIVITY_LOTTERY_EXECUTED, 'hms');
        $this->output[] = "Lottery system invoked on " . date("d M, Y @ g:i:s", $this->now) . " ($this->now)";
Severity: Major
Found in class/LotteryProcess.php - About 2 hrs to fix

Method getStudentProfile has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getStudentProfile($bannerId, $term)
    {
        // Sanity checking on the username
        if (empty($bannerId) || is_null($bannerId) || !isset($bannerId)) {
            throw new \InvalidArgumentException('Bad BannerId.');
Severity: Major
Found in class/FakeSoapTable.php - About 2 hrs to fix
Severity
Category
Status
Source
Language