Sign upLogin

AppStateESS/homestead

View on GitHub
Star

Showing 1,397 of 1,397 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function getBedByPersistentId($persistentId, $term)
    {
        $db = PdoFactory::getPdoInstance();

        $query = "select * from hms_bed where persistent_id = :persistentId AND term = :term";
Severity: Major
Found in class/BedFactory.php and 2 other locations - About 45 mins to fix
class/BedFactory.php on lines 32..48
class/RoomFactory.php on lines 35..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function get_study_matches($profile)
    {
        $study_matches = array();
        $m = new RoommateProfile;
Severity: Major
Found in class/RoommateProfileFactory.php and 2 other locations - About 45 mins to fix
class/RoommateProfileFactory.php on lines 79..94
class/RoommateProfileFactory.php on lines 105..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function getBedById($bedId, $term)
    {
        $db = PdoFactory::getPdoInstance();

        $query = "select * from hms_bed where id = :bedId AND term = :term";
Severity: Major
Found in class/BedFactory.php and 2 other locations - About 45 mins to fix
class/BedFactory.php on lines 14..29
class/RoomFactory.php on lines 35..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function get_music_matches($profile)
    {
        $music_matches = array();
        $m = new RoommateProfile;
Severity: Major
Found in class/RoommateProfileFactory.php and 2 other locations - About 45 mins to fix
class/RoommateProfileFactory.php on lines 79..94
class/RoommateProfileFactory.php on lines 128..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function getRoomById($roomId, $term)
    {
        $db = PdoFactory::getPdoInstance();

        $query = "select * from hms_room where id = :roomId AND term = :term";
Severity: Major
Found in class/RoomFactory.php and 2 other locations - About 45 mins to fix
class/BedFactory.php on lines 14..29
class/BedFactory.php on lines 32..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createArrowFunctionExpression has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        createArrowFunctionExpression: function (params, defaults, body, rest, expression, isAsync) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function checkIEEE754 has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function checkIEEE754 (buf, value, offset, ext, max, min) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function createClassDeclaration has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        createClassDeclaration: function (id, superClass, body, typeParameters, superTypeParameters, implemented) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function createClassExpression has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        createClassExpression: function (id, superClass, body, typeParameters, superTypeParameters, implemented) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function write has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

exports.write = function(buffer, value, offset, isLE, mLen, nBytes) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function checkInt has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function checkInt (buf, value, offset, ext, max, min) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function createProperty has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        createProperty: function (kind, key, value, method, shorthand, computed) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function rlcApplicationPager has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function rlcApplicationPager()
    {
        $submitCmd = CommandFactory::getCommand('AssignRlcApplicants');
        $form = new \PHPWS_Form;
        $submitCmd->initForm($form);
Severity: Minor
Found in class/RlcAssignmentView.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function show has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function show()
    {
        # Get the roommate request record from the database
        $bed = new Bed($this->request['bed_id']);
        $room = $bed->get_parent();
Severity: Minor
Found in class/LotteryConfirmRoommateRequestView.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          for (var i = 0; i < parentNode.params.length; i++) {
            param = parentNode.params[i];
            if (param.type === Syntax.Identifier) {
              declareIdentInScope(param.name, metadata, state);
            }
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        if (!((operator.value === 'in' || init.kind !== 'var') && init.declarations[0].init)) {
                            lex();
                            left = init;
                            right = parseExpression();
                            init = null;
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      if ((units -= 3) < 0) break
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if (extra.comments) {
                        comment = source.slice(start + 2, index - 2);
                        loc.end = {
                            line: lineNumber,
                            column: index - lineStart
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

            if (expr.argument.type === Syntax.ObjectPattern) {
                throwError({}, Messages.ObjectPatternAsSpread);
            }
Severity: Major
Found in javascript/react/build/JSXTransformer.js - About 45 mins to fix

Function getAdminCsvRow has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAdminCsvRow()
    {
        $row = array();

        // Get the RLC Application
Severity: Minor
Found in class/HMS_RLC_Assignment.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language