Sign upLogin

AppStateESS/homestead

View on GitHub
Star

Showing 1,397 of 1,397 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function load()
    {
        if($this->id == 0){
            return;
        }
Severity: Minor
Found in class/FallApplication.php and 2 other locations - About 40 mins to fix
class/LotteryApplication.php on lines 92..112
class/WaitingListApplication.php on lines 41..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function load()
    {
        if($this->id == 0){
            return;
        }
Severity: Minor
Found in class/WaitingListApplication.php and 2 other locations - About 40 mins to fix
class/FallApplication.php on lines 47..67
class/LotteryApplication.php on lines 92..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function load()
    {
        if($this->id == 0){
            return;
        }
Severity: Minor
Found in class/LotteryApplication.php and 2 other locations - About 40 mins to fix
class/FallApplication.php on lines 47..67
class/WaitingListApplication.php on lines 41..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function addComment has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    function addComment(type, value, start, end, loc) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function recursiveSearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function recursiveSearch(aLow, aHigh, aNeedle, aHaystack, aCompare) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function analyzeAndTraverse has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function analyzeAndTraverse(analyzer, traverser, node, path, state) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function createMethodDefinition has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        createMethodDefinition: function (propertyType, kind, key, value, computed) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function renderJSXExpressionContainer has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function renderJSXExpressionContainer(traverse, object, isLast, path, state) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function ajaxAddOption has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

$.fn.ajaxAddOption = function(url, params, select, fn, args)
Severity: Minor
Found in javascript/jquery.selectboxes.js - About 35 mins to fix

Function SourceNode has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function SourceNode(aLine, aColumn, aSource, aChunks, aName) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function writeFloat has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function writeFloat (buf, value, offset, littleEndian, noAssert) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function read has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

exports.read = function(buffer, offset, isLE, mLen, nBytes) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function _findMapping has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    function SourceMapConsumer_findMapping(aNeedle, aMappings, aLineName,
                                           aColumnName, aComparator) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function writeDouble has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function writeDouble (buf, value, offset, littleEndian, noAssert) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Function renderJSXLiteral has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function renderJSXLiteral(object, isLast, state, start, end) {
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 35 mins to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(Student $student, $startDate, $editDate, $endDate, $term)
Severity: Minor
Found in class/RoommateSelectionMenuBlockView.php - About 35 mins to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(Student $student, Bed $bed, $term, $checkinBy, $keyCode)
Severity: Minor
Found in class/Checkin.php - About 35 mins to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(Student $student, RoomChangeRequest $request, Array $participants, RoomChangeParticipant $thisParticipant, $term)
Severity: Minor
Found in class/RoomChangeRequestStudentApprovalView.php - About 35 mins to fix

Method makeRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public abstract function makeRequest($url, $method = 'GET', $headers = array(), $params = array(), $data = NULL);
Severity: Minor
Found in class/Docusign/IO.php - About 35 mins to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(Student $student, $term, $startDate, $endDate, HMS_Assignment $assignment = null)
Severity: Minor
Found in class/DamageMenuBlockView.php - About 35 mins to fix
Severity
Category
Status
Source
Language