Sign upLogin

AppStateESS/homestead

View on GitHub
Star
javascript/StudentAddRoomDamages/roomDamage.jsx

Summary

Maintainability
D
2 days
Test Coverage

File roomDamage.jsx has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import ReactDOM from 'react-dom';
import classNames from 'classnames';
import $ from 'jquery';
Severity: Minor
Found in javascript/StudentAddRoomDamages/roomDamage.jsx - About 5 hrs to fix

Function render has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render(){
        var options = Array({category:"Welcome", id: 0, description: "Select the type of damage"});//{id: 0, description: "Select the type of Damage"}

        var data = this.props.options;
        for(var i = 0; i < data.length; i++) {
Severity: Major
Found in javascript/StudentAddRoomDamages/roomDamage.jsx - About 3 hrs to fix

Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render(){
        if(this.props.roomDamages !== undefined) {
            var rows = this.props.roomDamages.map(function(node){
                return (
                    <tr key={node.id}>
Severity: Minor
Found in javascript/StudentAddRoomDamages/roomDamage.jsx - About 2 hrs to fix

Function render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render(){
        //console.log(this.props.newRoomDamages)
        if(this.props.newRoomDamages.length !== 0){
            var data = this.props.newRoomDamages;
            var removeRow = this.removeRow
Severity: Minor
Found in javascript/StudentAddRoomDamages/roomDamage.jsx - About 1 hr to fix

Function addUnsavedDamages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    addUnsavedDamages(type, sideInput, noteInput){
        var options = this.state.options

        var categ = '';
        var dmgTypeDesc = '';
Severity: Minor
Found in javascript/StudentAddRoomDamages/roomDamage.jsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    render(){
        var options = Array({category:"Welcome", id: 0, description: "Select the type of damage"});//{id: 0, description: "Select the type of Damage"}

        var data = this.props.options;
        for(var i = 0; i < data.length; i++) {
Severity: Minor
Found in javascript/StudentAddRoomDamages/roomDamage.jsx - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    getOptions(){
        $.ajax({
            url: 'index.php?module=hms&action=AjaxGetRoomDamageTypes',
            type: 'GET',
            dataType: 'json',
Severity: Major
Found in javascript/StudentAddRoomDamages/roomDamage.jsx and 1 other location - About 4 hrs to fix
javascript/RoomDamages/RoomDamages.jsx on lines 46..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          error: function(xhr, status, err) {
            alert("Failed to add room damages to database properly. "+ err.toString())
            console.error(this.props.url, status, err.toString());
          }.bind(this)
Severity: Major
Found in javascript/StudentAddRoomDamages/roomDamage.jsx and 1 other location - About 1 hr to fix
javascript/RoomDamages/RoomDamages.jsx on lines 68..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ReactDOM.render(<RoomDamageBox roomLocation={window.roomLocation} roomPID={window.roomPID} term={window.term}/>, document.getElementById('roomDamage'));
Severity: Major
Found in javascript/StudentAddRoomDamages/roomDamage.jsx and 1 other location - About 1 hr to fix
javascript/rlcMembersList/rlcMembersList.jsx on lines 401..401

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                            <UnsavedDamagesTable newRoomDamages={this.props.newDamages} removeRow={this.props.removeRoomDamages} saveDamages={this.props.saveDamages}/>
Severity: Major
Found in javascript/StudentAddRoomDamages/roomDamage.jsx and 2 other locations - About 50 mins to fix
javascript/AssignByFloor/AssignByFloor.jsx on lines 227..227
javascript/CheckOut/CheckOut.jsx on lines 97..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    <button onClick={this.removeRow} className="close pull-right">
                      <i className="fa fa-trash"></i>
                    </button>
Severity: Minor
Found in javascript/StudentAddRoomDamages/roomDamage.jsx and 1 other location - About 30 mins to fix
javascript/RoomDamages/RoomDamages.jsx on lines 143..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status