Sign upLogin

AppStateESS/homestead

View on GitHub
Star
javascript/damageAssessment/DamageAssessment.jsx

Summary

Maintainability
C
1 day
Test Coverage

File DamageAssessment.jsx has 286 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import ReactDOM from 'react-dom';
import ReactCSSTransitionGroup from 'react-addons-css-transition-group';
import $ from 'jquery';
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx - About 2 hrs to fix

Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render(){
        var damageItems = this.state.damages.map(function(damage){
            return (
                <DamageItem key={damage.id} damage={damage} damageTypes={this.props.damageTypes} updateResponsibilityCallback={this.updateResponsibility}/>
            );
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx - About 1 hr to fix

Function render has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        // Get the damageType (name, desc, cost) from the list of damageTypes based on this damage's type id
        var dmgType = this.props.damageTypes[this.props.damage.damage_type];

        // Setup the list of students responsible for this damage
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx - About 1 hr to fix

Function componentWillMount has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    componentWillMount(){
        // Load the list of damage types
        $.ajax({
            url: 'index.php?module=hms&action=GetDamageTypes',
            data: {term: this.props.term},
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx - About 1 hr to fix

Function findIndex has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  Array.prototype.findIndex = function(predicate) {
    if (this === null) {
      throw new TypeError('Array.prototype.findIndex called on null or undefined');
    }
    if (typeof predicate !== 'function') {
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateResponsibility has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    updateResponsibility(responsiblity){
        // Find the corresponding responsiblity in our current state and update it
        var currentDamages = this.state.damages;

        var dmgIndex = currentDamages.findIndex(function(element, index, arr){
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var respIndex = currentResp.findIndex(function(element, index, arr){
            if(responsiblity.id === element.id){
                return true;
            } else {
                return false;
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx and 1 other location - About 50 mins to fix
javascript/damageAssessment/DamageAssessment.jsx on lines 146..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var dmgIndex = currentDamages.findIndex(function(element, index, arr){
            if(responsiblity.damage_id === element.id){
                return true;
            } else {
                return false;
Severity: Minor
Found in javascript/damageAssessment/DamageAssessment.jsx and 1 other location - About 50 mins to fix
javascript/damageAssessment/DamageAssessment.jsx on lines 157..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status