Sign upLogin

Arafatk/DataViz

View on GitHub
Star
trees/btree/btree.go

Summary

Maintainability
D
1 day
Test Coverage

Tree has 44 methods (exceeds 20 allowed). Consider refactoring.
Open

type Tree struct {
    Root       *Node            // Root node
    Comparator utils.Comparator // Key comparator
    size       int              // Total number of keys in the tree
    m          int              // order (maximum number of children)
Severity: Minor
Found in trees/btree/btree.go - About 6 hrs to fix

    File btree.go has 502 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    // Package btree implements a B tree.
//
// According to Knuth's definition, a B-tree of order m is a tree which satisfies the following properties:
// - Every node has at most m children.
// - Every non-leaf node (except root) has at least ⌈m/2⌉ children.
    Severity: Minor
    Found in trees/btree/btree.go - About 2 hrs to fix

      Method Tree.Visualizer has 61 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (tree *Tree) Visualizer(fileName string) bool {
    it := tree.Iterator()
    dotString := "digraph G{bgcolor=azure;"
    nodeIndexCount := 0
    subGraphNumber := 0
      Severity: Minor
      Found in trees/btree/btree.go - About 1 hr to fix

        Method Tree.Visualizer has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
        Open

        func (tree *Tree) Visualizer(fileName string) bool {
    it := tree.Iterator()
    dotString := "digraph G{bgcolor=azure;"
    nodeIndexCount := 0
    subGraphNumber := 0
        Severity: Minor
        Found in trees/btree/btree.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Tree.rebalance has 51 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (tree *Tree) rebalance(node *Node, deletedKey interface{}) {
    // check if rebalancing is needed
    if node == nil || len(node.Entries) >= tree.minEntries() {
        return
    }
        Severity: Minor
        Found in trees/btree/btree.go - About 1 hr to fix

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func (tree *Tree) Keys() []interface{} {
    keys := make([]interface{}, tree.size)
    it := tree.Iterator()
    for i := 0; it.Next(); i++ {
        keys[i] = it.Key()
          Severity: Major
          Found in trees/btree/btree.go and 5 other locations - About 35 mins to fix
          trees/avltree/avltree.go on lines 93..100
          trees/avltree/avltree.go on lines 103..110
          trees/btree/btree.go on lines 130..137
          trees/redblacktree/redblacktree.go on lines 156..163
          trees/redblacktree/redblacktree.go on lines 166..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func (tree *Tree) Values() []interface{} {
    values := make([]interface{}, tree.size)
    it := tree.Iterator()
    for i := 0; it.Next(); i++ {
        values[i] = it.Value()
          Severity: Major
          Found in trees/btree/btree.go and 5 other locations - About 35 mins to fix
          trees/avltree/avltree.go on lines 93..100
          trees/avltree/avltree.go on lines 103..110
          trees/btree/btree.go on lines 120..127
          trees/redblacktree/redblacktree.go on lines 156..163
          trees/redblacktree/redblacktree.go on lines 166..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status