Sign upLogin

Arie/serveme

View on GitHub
Star
app/models/reservation.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Reservation has 57 methods (exceeds 20 allowed). Consider refactoring.
Open

class Reservation < ActiveRecord::Base
  belongs_to :user
  belongs_to :server
  belongs_to :server_config, optional: true
  belongs_to :whitelist, optional: true
Severity: Major
Found in app/models/reservation.rb - About 1 day to fix

    Method status has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def status
    return 'Ended' if past?

    status_messages = reservation_statuses.pluck(:status)
    return 'Ended' if status_messages.include?('Finished zipping logs and demos')
    Severity: Minor
    Found in app/models/reservation.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return 'Ready' if server_statistics.any? && !server.sdr?
    Severity: Major
    Found in app/models/reservation.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return 'Starting' if status_messages.include?('Starting')
      Severity: Major
      Found in app/models/reservation.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return 'Server updating, please be patient' if status_messages.grep(/\AServer outdated/).any?
        Severity: Major
        Found in app/models/reservation.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return 'Ready' if status_messages.grep(/\AServer finished loading map/).any? && !server.sdr?
          Severity: Major
          Found in app/models/reservation.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return 'Waiting to start' if status_messages.include?('Waiting to start')
            Severity: Major
            Found in app/models/reservation.rb - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status