Sign upLogin

ArtOfCode-/qpixel

View on GitHub
Star

Showing 164 of 164 total issues

Function HBKeyboard has 207 lines of code (exceeds 25 allowed). Consider refactoring.
Open

(function HBKeyboard() {
  var docCookies = { //from developer.mozilla.org/en-US/docs/Web/API/document.cookie
    getItem: function (sKey) {
      return unescape(document.cookie.replace(new RegExp("(?:(?:^|.*;)\\s*" + escape(sKey).replace(/[\-\.\+\*]/g, "\\$&") + "\\s*\\=\\s*([^;]*).*$)|^.*$"), "$1")) || null;
    },
Severity: Major
Found in public/assets/community/judaism.js - About 1 day to fix

    File posts_controller.rb has 445 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class PostsController < ApplicationController
  before_action :authenticate_user!, except: [:document, :help_center, :show]
  before_action :set_post, only: [:toggle_comments, :feature, :lock, :unlock]
  before_action :set_scoped_post, only: [:change_category, :show, :edit, :update, :close, :reopen, :delete, :restore]
  before_action :verify_moderator, only: [:toggle_comments]
    Severity: Minor
    Found in app/controllers/posts_controller.rb - About 6 hrs to fix

      Method update has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
      Open

        def update
    before = { body: @post.body_markdown, title: @post.title, tags: @post.tags }
    after_tags = if @post_type.has_category?
                   Tag.where(tag_set_id: @post.category.tag_set_id, name: params[:post][:tags_cache])
                 end
      Severity: Minor
      Found in app/controllers/posts_controller.rb - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File judaism.js has 389 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
The MIT License (MIT)
Copyright (c) 2013  HodofHod (https://github.com/HodofHod, http://judaism.stackexchange.com/users/883/hodofhod)
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
      Severity: Minor
      Found in public/assets/community/judaism.js - About 5 hrs to fix

        Method qualifiers_to_sql has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
        Open

          def qualifiers_to_sql(qualifiers)
    valid_value = {
      date: /^[<>=]{0,2}\d+(?:s|m|h|d|w|mo|y)?$/,
      numeric: /^[<>=]{0,2}\d+$/
    }
        Severity: Minor
        Found in app/helpers/search_helper.rb - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createKeyboard has 127 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function createKeyboard() {
    var stand = "קראטוןםפשדגכעיחלךףזסבהנמצתץ",
      alpha = "חזוהדגבאסןנםמלךכיטתשרקץצףפע",
      nek = ["שׁ", "שׂ", "וְ", "וֱ", "וֲ", "וֳ", "וִ", "וֵ", "וֶ", "וַ", "וָ", "וֹ", "וֻ", "וּ"],
      x = 50,
        Severity: Major
        Found in public/assets/community/judaism.js - About 5 hrs to fix

          File users_controller.rb has 346 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'net/http'

# rubocop:disable Metrics/ClassLength
class UsersController < ApplicationController
  include Devise::Controllers::Rememberable
          Severity: Minor
          Found in app/controllers/users_controller.rb - About 4 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (warnings.length > 0) {
          const $warningBox = $(`<div class="notice is-warning"></div>`);
          const $warningList = $(`<ul></ul>`);
          warnings.forEach(w => {
            $warningList.append(`<li>${w['message']}</li>`);
            Severity: Major
            Found in app/assets/javascripts/posts.js and 1 other location - About 4 hrs to fix
            app/assets/javascripts/posts.js on lines 195..203

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 118.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (errors.length > 0) {
          const $errorBox = $(`<div class="notice is-danger"></div>`);
          const $errorList = $(`<ul></ul>`);
          errors.forEach(e => {
            $errorList.append(`<li>${e['message']}</li>`);
            Severity: Major
            Found in app/assets/javascripts/posts.js and 1 other location - About 4 hrs to fix
            app/assets/javascripts/posts.js on lines 185..193

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 118.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File advertisement_controller.rb has 327 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'rmagick'
require 'open-uri'

# Necessary due to rmagick
# rubocop:disable Metrics/MethodLength
            Severity: Minor
            Found in app/controllers/advertisement_controller.rb - About 3 hrs to fix

              Class Post has 31 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class Post < ApplicationRecord
  include CommunityRelated

  belongs_to :user
  belongs_to :post_type
              Severity: Minor
              Found in app/models/post.rb - About 3 hrs to fix

                Class PostsController has 27 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class PostsController < ApplicationController
  before_action :authenticate_user!, except: [:document, :help_center, :show]
  before_action :set_post, only: [:toggle_comments, :feature, :lock, :unlock]
  before_action :set_scoped_post, only: [:change_category, :show, :edit, :update, :close, :reopen, :delete, :restore]
  before_action :verify_moderator, only: [:toggle_comments]
                Severity: Minor
                Found in app/controllers/posts_controller.rb - About 3 hrs to fix

                  Function homeMenu has 78 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function homeMenu(e) {
        if (e.key === "?") {
            _CodidactKeyboard.dialog('Codidact Keyboard Shortcuts\n' +
                '===========================\n' +
                '?  Open this help\n' +
                  Severity: Major
                  Found in app/assets/javascripts/keyboard_tools.js - About 3 hrs to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const resp = await fetch(`/users/${$tgt.attr('data-user')}/mod/privileges`, {
      method: 'POST',
      body: JSON.stringify({ do: 'delete', ability: $tgt.attr('data-ability') }),
      headers: { 'Content-Type': 'application/json', 'X-CSRF-Token': QPixel.csrfToken() },
      credentials: 'include'
                    Severity: Major
                    Found in app/assets/javascripts/users.js and 1 other location - About 3 hrs to fix
                    app/assets/javascripts/users.js on lines 26..31

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const resp = await fetch(`/users/${$tgt.attr('data-user')}/mod/privileges`, {
      method: 'POST',
      body: JSON.stringify({ do: 'grant', ability: $tgt.attr('data-ability') }),
      headers: { 'Content-Type': 'application/json', 'X-CSRF-Token': QPixel.csrfToken() },
      credentials: 'include'
                    Severity: Major
                    Found in app/assets/javascripts/users.js and 1 other location - About 3 hrs to fix
                    app/assets/javascripts/users.js on lines 44..49

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method do_rtl_witchcraft has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def do_rtl_witchcraft(str)
    chars = str.chars
    output_buffer = ''
    scan_buffer = []
    current_mode = rtl?(chars[0]) ? :rtl : :ltr
                    Severity: Minor
                    Found in app/helpers/advertisement_helper.rb - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method create has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def create
    @post_type = PostType.find(params[:post][:post_type_id])
    @parent = Post.where(id: params[:parent]).first
    @category = if @post_type.has_category
                  if params[:post][:category_id].present?
                    Severity: Minor
                    Found in app/controllers/posts_controller.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File keyboard_tools.js has 286 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    $(() => {
    const userLink = $('.header--item.is-complex.is-visible-on-mobile[href^="/users/"]').attr('href');
    const keyboardToolsAreEnabled = !!window.localStorage.getItem("keyboard__enable");

    $(".js-keyboard_tools-status").text(keyboardToolsAreEnabled ? "activated" : "inactive");
                    Severity: Minor
                    Found in app/assets/javascripts/keyboard_tools.js - About 2 hrs to fix

                      Method question_ad has 71 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def question_ad(question)
    ad = Rails.cache.fetch "posts/#{question.id}/ad", expires_in: 60.minutes do
      ad = Image.new(600, 500)
      ad.background_color = 'white'
                      Severity: Major
                      Found in app/controllers/advertisement_controller.rb - About 2 hrs to fix

                        Method create has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                        Open

                          def create
    @post = Post.find(params[:comment][:post_id])
    if @post.comments_disabled && !current_user.is_moderator && !current_user.is_admin
      render json: { status: 'failed', message: 'Comments have been disabled on this post.' }, status: :forbidden
      return
                        Severity: Minor
                        Found in app/controllers/comments_controller.rb - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language