ArtifactForms/MeshLibCore

View on GitHub
src/main/java/math/Mathf.java

Summary

Maintainability
C
1 day
Test Coverage

Mathf has 56 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Mathf {

  /** A random number generator used to generate random values. */
  private static Random random = new Random();

Severity: Major
Found in src/main/java/math/Mathf.java - About 1 day to fix

    Method map has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      public static float map(float value, float from0, float to0, float from1, float to1) {
    Severity: Minor
    Found in src/main/java/math/Mathf.java - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public static float max(float... values) {
          if (values.length == 0) return Float.NaN;
      
          float max = values[0];
          for (int i = 1; i < values.length; i++) max = Math.max(max, values[i]);
      Severity: Major
      Found in src/main/java/math/Mathf.java and 1 other location - About 1 hr to fix
      src/main/java/math/Mathf.java on lines 198..204

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public static float min(float... values) {
          if (values.length == 0) return Float.NaN;
      
          float min = values[0];
          for (int i = 1; i < values.length; i++) min = Math.min(min, values[i]);
      Severity: Major
      Found in src/main/java/math/Mathf.java and 1 other location - About 1 hr to fix
      src/main/java/math/Mathf.java on lines 184..190

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public static int max(int[] values) {
          if (values.length == 0) return 0;
      
          int max = values[0];
          for (int i = 1; i < values.length; i++) max = Math.max(max, values[i]);
      Severity: Major
      Found in src/main/java/math/Mathf.java and 1 other location - About 1 hr to fix
      src/main/java/math/Mathf.java on lines 134..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public static int min(int[] values) {
          if (values.length == 0) return 0;
      
          int min = values[0];
          for (int i = 1; i < values.length; i++) min = Math.min(min, values[i]);
      Severity: Major
      Found in src/main/java/math/Mathf.java and 1 other location - About 1 hr to fix
      src/main/java/math/Mathf.java on lines 148..154

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status