ArtifactForms/MeshLibCore

View on GitHub
src/main/java/math/Vector2f.java

Summary

Maintainability
D
2 days
Test Coverage

Vector2f has 69 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Vector2f {

  /** Shorthand for writing Vector2f(0, -1). */
  public static final Vector2f DOWN = new Vector2f(0, -1);

Severity: Major
Found in src/main/java/math/Vector2f.java - About 1 day to fix

    File Vector2f.java has 368 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package math;
    
    /**
     * Representation of 2D vectors and points.
     *
    Severity: Minor
    Found in src/main/java/math/Vector2f.java - About 4 hrs to fix

      Avoid too many return statements within this method.
      Open

          if (Float.floatToIntBits(y) != Float.floatToIntBits(other.y)) return false;
      Severity: Major
      Found in src/main/java/math/Vector2f.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return true;
        Severity: Major
        Found in src/main/java/math/Vector2f.java - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            public Vector2f max(Vector2f v) {
              if (v == null) {
                return null;
              }
              return new Vector2f(Mathf.max(x, v.x), Mathf.max(y, v.y));
          Severity: Minor
          Found in src/main/java/math/Vector2f.java and 1 other location - About 30 mins to fix
          src/main/java/math/Vector2f.java on lines 108..113

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            public Vector2f min(Vector2f v) {
              if (v == null) {
                return null;
              }
              return new Vector2f(Mathf.min(x, v.x), Mathf.min(y, v.y));
          Severity: Minor
          Found in src/main/java/math/Vector2f.java and 1 other location - About 30 mins to fix
          src/main/java/math/Vector2f.java on lines 123..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            public Vector2f subtractLocal(Vector2f v) {
              if (null == v) {
                return null;
              }
              x -= v.x;
          Severity: Minor
          Found in src/main/java/math/Vector2f.java and 2 other locations - About 30 mins to fix
          src/main/java/math/Vector2f.java on lines 290..297
          src/main/java/math/Vector2f.java on lines 537..544

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            public Vector2f addLocal(Vector2f v) {
              if (null == v) {
                return null;
              }
              x += v.x;
          Severity: Minor
          Found in src/main/java/math/Vector2f.java and 2 other locations - About 30 mins to fix
          src/main/java/math/Vector2f.java on lines 537..544
          src/main/java/math/Vector2f.java on lines 673..680

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            public Vector2f multLocal(Vector2f v) {
              if (null == v) {
                return null;
              }
              x *= v.x;
          Severity: Minor
          Found in src/main/java/math/Vector2f.java and 2 other locations - About 30 mins to fix
          src/main/java/math/Vector2f.java on lines 290..297
          src/main/java/math/Vector2f.java on lines 673..680

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status