Sign upLogin

ArtifactForms/MeshLibCore

View on GitHub
Star
src/main/java/mesh/modifier/subdivision/DooSabinModifier.java

Summary

Maintainability
B
6 hrs
Test Coverage

Method equals has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        @Override
        public boolean equals(Object obj) {
            if (this == obj)
                return true;
            if (obj == null)
Severity: Minor
Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                    return false;
Severity: Major
Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return true;
    Severity: Major
    Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return false;
      Severity: Major
      Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return false;
          Severity: Major
          Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

            Method mapEdgesToFaces has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private void mapEdgesToFaces() {
        for (Face3D face : source.faces) {
            for (int i = 0; i < face.indices.length; i++) {
                int a = face.indices[i];
                int b = face.indices[(i + 1) % face.indices.length];
            Severity: Minor
            Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private void addFace(Vector<Integer> indices) {
        int[] a = new int[indices.size()];
        for (int j = 0; j < a.length; j++) {
            a[a.length - j - 1] = indices.get(j);
        }
            Severity: Major
            Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java and 1 other location - About 1 hr to fix
            src/main/java/mesh/creator/special/DualCreator.java on lines 26..32

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 76.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                        if (vertex == null) {
                if (other.vertex != null)
                    return false;
            } else if (!vertex.equals(other.vertex))
                return false;
            Severity: Major
            Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java and 3 other locations - About 30 mins to fix
            src/main/java/mesh/modifier/subdivision/DooSabinModifier.java on lines 249..253
            src/main/java/mesh/util/Bounds3.java on lines 233..237
            src/main/java/mesh/util/Bounds3.java on lines 238..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                        if (face == null) {
                if (other.face != null)
                    return false;
            } else if (!face.equals(other.face))
                return false;
            Severity: Major
            Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java and 3 other locations - About 30 mins to fix
            src/main/java/mesh/modifier/subdivision/DooSabinModifier.java on lines 254..258
            src/main/java/mesh/util/Bounds3.java on lines 233..237
            src/main/java/mesh/util/Bounds3.java on lines 238..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status