Sign upLogin

ArtifactForms/MeshLibCore

View on GitHub
Star
src/main/java/workspace/render/Mesh3DRenderer.java

Summary

Maintainability
C
1 day
Test Coverage

Method drawFacesColored has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  public void drawFacesColored(Mesh3D mesh) {
    context.pushMatrix();
    for (Face3D f : mesh.faces) {
      context.fill(f.color.getRedInt(), f.color.getGreenInt(), f.color.getBlueInt());
Severity: Minor
Found in src/main/java/workspace/render/Mesh3DRenderer.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method drawFacesSmooth has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  private void drawFacesSmooth(Mesh3D mesh, Collection<Face3D> faces) {
    context.pushMatrix();

    mesh.apply(new UpdateFaceNormalsModifier());
Severity: Minor
Found in src/main/java/workspace/render/Mesh3DRenderer.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method drawFacesSmooth has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private void drawFacesSmooth(Mesh3D mesh, Collection<Face3D> faces) {
    context.pushMatrix();

    mesh.apply(new UpdateFaceNormalsModifier());
Severity: Minor
Found in src/main/java/workspace/render/Mesh3DRenderer.java - About 1 hr to fix

    Method drawFacesFlat has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      private void drawFacesFlat(PGraphics3D context, Mesh3D mesh, Collection<Face3D> faces) {
    for (Face3D f : faces) {
      Vector3f v;

      // Use specific shape types based on face vertex count
    Severity: Minor
    Found in src/main/java/workspace/render/Mesh3DRenderer.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method drawCheckerGrid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      public void drawCheckerGrid(int rows, int cols, float size) {
    context.pushStyle();
    context.noStroke();

    context.pushMatrix();
    Severity: Minor
    Found in src/main/java/workspace/render/Mesh3DRenderer.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        for (int i = 0; i < rows; i++) {
      for (int j = 0; j < cols; j++) {
        context.rect(j * size, i * size, size, size);
      }
    }
    Severity: Minor
    Found in src/main/java/workspace/render/Mesh3DRenderer.java and 1 other location - About 50 mins to fix
    src/main/java/workspace/ui/ui3d/Grid3D.java on lines 71..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

          for (int i = 0; i < f.indices.length; i++) {
        v = mesh.vertices.get(f.indices[i]);
        context.vertex(v.getX(), v.getY(), v.getZ());
      }
    Severity: Major
    Found in src/main/java/workspace/render/Mesh3DRenderer.java and 2 other locations - About 50 mins to fix
    src/main/java/workspace/render/ObjectSelectionRender.java on lines 105..108
    src/main/java/workspace/render/SelectionRenderer.java on lines 91..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (f.indices.length == 3) {
        context.beginShape(PApplet.TRIANGLES);
      } else if (f.indices.length == 4) {
        context.beginShape(PApplet.QUADS);
      } else {
    Severity: Minor
    Found in src/main/java/workspace/render/Mesh3DRenderer.java and 1 other location - About 50 mins to fix
    src/main/java/workspace/GraphicsPImpl.java on lines 128..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        for (int i = 0; i < mesh.vertices.size(); i++) {
      Vector3f v = mesh.vertices.get(i);
      context.vertex(v.getX(), v.getY(), v.getZ());
    }
    Severity: Minor
    Found in src/main/java/workspace/render/Mesh3DRenderer.java and 1 other location - About 45 mins to fix
    src/main/java/workspace/render/Mesh3DRenderer.java on lines 26..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        for (int i = 0; i < mesh.vertices.size(); i++) {
      Vector3f v = mesh.vertices.get(i);
      context.vertex(v.getX(), v.getY(), v.getZ());
    }
    Severity: Minor
    Found in src/main/java/workspace/render/Mesh3DRenderer.java and 1 other location - About 45 mins to fix
    src/main/java/workspace/render/Mesh3DRenderer.java on lines 39..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status