Sign upLogin

Arubacloud/pyArubaCloud

View on GitHub
Star

Showing 94 of 94 total issues

Avoid deeply nested control flow statements.
Open

                        if resource_type == 7:
                            o.resource_bounds.hdd1 = rb['Max']
                        if resource_type == 8:
Severity: Major
Found in ArubaCloud/PyArubaAPI.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if resource_type == 8:
                            o.resource_bounds.hdd2 = rb['Max']
                        if resource_type == 9:
    Severity: Major
    Found in ArubaCloud/PyArubaAPI.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if resource_type == 2:
                            o.resource_bounds.max_memory = rb['Max']
                        if resource_type == 3:
      Severity: Major
      Found in ArubaCloud/PyArubaAPI.py - About 45 mins to fix

        Function _log_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def _log_request(logger, data=None, headers=None):
        if logger is not None:
            if headers is not None:
                for header in headers:
                    logger.debug('request header: %s: %s', header, headers[header])
        Severity: Minor
        Found in ArubaCloud/helper/__init__.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if resource_type == 9:
                            o.resource_bounds.hdd3 = rb['Max']
                self.templates.append(o)
        Severity: Major
        Found in ArubaCloud/PyArubaAPI.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if resource_type == 3:
                            o.resource_bounds.hdd0 = rb['Max']
                        if resource_type == 7:
          Severity: Major
          Found in ArubaCloud/PyArubaAPI.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            if server_detail['ServerStatus'] == 2:
                    break
                else:
                    print('Waiting shutdown for other %s seconds' % sleep_for)
                    time.sleep(sleep_for)
            Severity: Major
            Found in examples/forced_restart_vm.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if resource_type == 1:
                            o.resource_bounds.max_cpu = rb['Max']
                        if resource_type == 2:
              Severity: Major
              Found in ArubaCloud/PyArubaAPI.py - About 45 mins to fix

                Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def __init__(self, startDate, endDate, loadBalancerID, loadBalancerRuleID, *args, **kwargs):
                Severity: Minor
                Found in ArubaCloud/Compute/LoadBalancer/Requests/GetLoadBalancerNotifications.py - About 45 mins to fix

                  Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def __init__(self, name, admin_password, template_id, auth_obj, note=None):
                  Severity: Minor
                  Found in ArubaCloud/objects/__init__.py - About 35 mins to fix

                    Function attach_vlan has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def attach_vlan(self, network_adapter_id, vlan_resource_id, ip=None, subnet_mask=None, gateway=None):
                    Severity: Minor
                    Found in ArubaCloud/PyArubaAPI.py - About 35 mins to fix

                      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def __init__(self, level=logging.DEBUG, dst_file='debug.log', name=__name__, log_to_file=False,
                      Severity: Minor
                      Found in ArubaCloud/base/logsystem.py - About 35 mins to fix

                        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def __init__(self, name, admin_password, template_id, auth_obj, note=None):
                        Severity: Minor
                        Found in ArubaCloud/objects/__init__.py - About 35 mins to fix

                          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def __init__(self, startDate, endDate, loadBalancerRuleID, *args, **kwargs):
                          Severity: Minor
                          Found in ArubaCloud/Compute/LoadBalancer/Requests/GetLoadBalancerRuleStatistics.py - About 35 mins to fix

                            Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def __init__(self, startDate, endDate, loadBalancerID, *args, **kwargs):
                            Severity: Minor
                            Found in ArubaCloud/Compute/LoadBalancer/Requests/GetLoadBalancerLoads.py - About 35 mins to fix

                              Function get_package_id has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  def get_package_id(self, name):
        """
        Retrieve the smart package id given is English name
        @param (str) name: the Aruba Smart package size name, ie: "small", "medium", "large", "extra large".
        @return: The package id that depends on the Data center and the size choosen.
                              Severity: Minor
                              Found in ArubaCloud/PyArubaAPI.py - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  def _call(self, method, *args, **kwargs):
        return method(Username=self.username, Password=self.password, uri=self.ws_uri, *args, **kwargs)
                              Severity: Minor
                              Found in ArubaCloud/SharedStorage/SharedStorage.py and 1 other location - About 30 mins to fix
                              ArubaCloud/ReverseDns/ReverseDns.py on lines 9..10

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  def _call(self, method, *args, **kwargs):
        return method(Username=self.username, Password=self.password, uri=self.ws_uri, *args, **kwargs)
                              Severity: Minor
                              Found in ArubaCloud/ReverseDns/ReverseDns.py and 1 other location - About 30 mins to fix
                              ArubaCloud/SharedStorage/SharedStorage.py on lines 10..11

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              XXX found
                              Open

                              ci.login(username="XXX-XXXX", password="XXXXXXXX", load=True)
                              Severity: Minor
                              Found in README.md by fixme

                              XXX found
                              Open

                              print(rdns.get(addresses=['XXX.XXX.XXX.XXX']))
                              Severity: Minor
                              Found in README.md by fixme
                              Severity
                              Category
                              Status
                              Source
                              Language