Sign upLogin

AsgardCms/Menu

View on GitHub
Star
Services/MenuRenderer.php

Summary

Maintainability
A
1 hr
Test Coverage

Method generateHtmlFor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function generateHtmlFor($items)
    {
        $this->menu .= '<ol class="dd-list">';
        foreach ($items as $item) {
            $this->menu .= "<li class=\"dd-item\" data-id=\"{$item->id}\">";
Severity: Minor
Found in Services/MenuRenderer.php - About 1 hr to fix

    Function generateHtmlFor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function generateHtmlFor($items)
    {
        $this->menu .= '<ol class="dd-list">';
        foreach ($items as $item) {
            $this->menu .= "<li class=\"dd-item\" data-id=\"{$item->id}\">";
    Severity: Minor
    Found in Services/MenuRenderer.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status